Repository navigation
Conversation
Adds runcrate/<model> through Runcrate's OpenAI-compatible API (https://api.runcrate.ai/v1), with RUNCRATE_API_KEY and an optional RUNCRATE_BASE_URL or runcrate.baseUrl override. Wired like the nvidia provider: gateway registry, model resolution, env state, daemon model picker and status, config, docs, and help text.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR adds Runcrate-specific model names, credentials, endpoint settings, model discovery, status output, documentation, and tests. Example: Select meta-llama/Llama-3.3-70B-Instruct-Turbo on Runcrate.
Review scores
ProductKind: Feature · Worth it: No · Fix scope: Complete Merge readiness⛔ Blocked before merge - 5 items remain Keep open under the repository’s no-auto-close policy, but do not merge the dedicated provider: an explicit owner decision directs OpenAI-compatible gateways through the existing custom-endpoint support. Priority: P3 Before merge
Findings
Provenance
Tests
Agent review detailsHow this fits togetherThe CLI and companion daemon resolve model names, credentials, and endpoints through shared provider configuration, then send extracted content to an inference API and return summaries or discovered model choices. flowchart TD
A[CLI or companion daemon] --> B[Model and configuration resolution]
C[Credentials and endpoint] --> B
B --> D[Shared OpenAI compatible transport]
D --> E[Runcrate API]
E --> F[Summary or model list]
Technical reviewBest possible solution: Document a Runcrate example using the existing OpenAI endpoint configuration and model namespace. Do we have a high-confidence way to reproduce the issue? This is a provider feature, not a reported runtime bug; source inspection confirms that main lacks the Runcrate namespace but already supports custom endpoints and model discovery. Is this the best way to solve the issue? The dedicated integration follows existing implementation patterns, but the owner’s subsequent gateway policy makes a configuration example the appropriate solution. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against aaccb7c9c30e. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 9, 2026, 2:04 AM ET / 07:04 UTC. |
Drop the dedicated runcrate provider and document the existing OPENAI_BASE_URL path instead.
|
I dropped the dedicated provider (commit 3f49865 reverts efd770c), since #504 says gateways should go through OPENAI_BASE_URL. The PR is now only a docs example in docs/llm.md, so there are no source, config or stored-data changes to migrate. What I ran on the new head (Node 26, pnpm 11.27.0): The documented path against a local mock OpenAI-compatible server on 127.0.0.1 (dummy key,
|
Per the maintainer's note on #504, this no longer adds a dedicated provider. It now only adds a short docs section (
docs/llm.md, "OpenAI-compatible gateways") showing how to use Runcrate, an AI cloud with an OpenAI-compatible API, through the existingOPENAI_BASE_URLandOPENAI_API_KEYsettings:No source, config schema, env var or stored-data changes, so there is nothing to migrate.
How it was checked:
oxfmt --check docs/llm.md,pnpm run typecheck, and the provider tests (provider-registry.contract,model-spec,cli.llm.providers,daemon.models): 70 passed.GET https://api.runcrate.ai/v1/models(public, no key) listsmeta-llama/Llama-3.3-70B-Instruct-Turbo.POST /v1/chat/completionswith the model id passed through asmeta-llama/Llama-3.3-70B-Instruct-Turbo.Disclosure: I work on Runcrate.
This PR was prepared with AI assistance (omp with Claude): the docs, this description and the commands above were written and run with it.