Repository navigation
workspace: allow the permissive licenses already present in the dependency tree - #15111
avi-starkware wants to merge 1 commit into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
84a8a4d to
4acca62
Compare
4acca62 to
87eaa9c
Compare
87eaa9c to
b8f0246
Compare
PR SummaryLow Risk Overview
This is policy/config only; known failures (e.g. GPL Reviewed by Cursor Bugbot for commit c0f4a93. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
b8f0246 to
e3a6bd8
Compare
e3a6bd8 to
88000a9
Compare
3a67514 to
fd25779
Compare
e0480eb to
5eecb12
Compare
5eecb12 to
249d6ce
Compare
249d6ce to
dfe663c
Compare
dfe663c to
3c7b961
Compare
3c7b961 to
50a9346
Compare
…dency tree Unicode-3.0, ISC, CDLA-Permissive-2.0, BSL-1.0, bzip2-1.0.6, Apache-2.0 WITH LLVM-exception are permissive, and MPL-2.0 is file-level weak copyleft, so allowing them drops the license rejections from 41 to one without changing what the workspace may be distributed under. bench_tools was the only workspace member that did not inherit the workspace license field, so it now does. The one remaining rejection is rhexdump, which is GPL-3.0-or-later and reaches the starknet_committer_cli binary through aerospike, so it stays rejected pending a licensing decision and the licenses step stays non-blocking. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
50a9346 to
c0f4a93
Compare
Allows the license families already present in the dependency tree: Unicode-3.0, ISC, MPL-2.0, CDLA-Permissive-2.0, BSL-1.0, bzip2-1.0.6, Apache-2.0 WITH LLVM-exception — all permissive or file-level weak copyleft. License rejections (
error[rejected]) drop 41 → 1; the 7error[unlicensed]findings below are a separate class and unchanged (8 → 7 via thebench_toolsfix).bench_toolswas the only workspace member not inheriting the workspace license field; it now does.Deliberately left failing — needs a decision, not a config edit:
rhexdump 0.2.0is GPL-3.0-or-later, reached viaaerospike = "=2.0.0-alpha.6"→starknet_patricia_storage[aerospike_storage], whichstarknet_committer_clienables — i.e. it is in a shipped binary.unlicensed: thestwo-circuitsgit crates declare nolicense. Fix is one line upstream (license = "Apache-2.0"in that repo's[workspace.package]); cargo-deny 0.20 cannot clarify them here without per-crate license files.Because of those, the licenses step stays non-blocking (previous PR).
[licenses.private] ignoreis keptfalsewith a comment: the workspace-only crates are nowpublish = false, and flipping it would silently drop all 99 from the license check.🤖 Generated with Claude Code