Skip to content

workspace: allow the permissive licenses already present in the dependency tree - #15111

Open
avi-starkware wants to merge 1 commit into
avi/deps/04-advisories-gatefrom
avi/deps/05-license-allowlist
Open

avi-starkware wants to merge 1 commit into
avi/deps/04-advisories-gatefrom
avi/deps/05-license-allowlist

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

Allows the license families already present in the dependency tree: Unicode-3.0, ISC, MPL-2.0, CDLA-Permissive-2.0, BSL-1.0, bzip2-1.0.6, Apache-2.0 WITH LLVM-exception — all permissive or file-level weak copyleft. License rejections (error[rejected]) drop 41 → 1; the 7 error[unlicensed] findings below are a separate class and unchanged (8 → 7 via the bench_tools fix). bench_tools was the only workspace member not inheriting the workspace license field; it now does.

Deliberately left failing — needs a decision, not a config edit:

  • rhexdump 0.2.0 is GPL-3.0-or-later, reached via aerospike = "=2.0.0-alpha.6" → starknet_patricia_storage[aerospike_storage], which starknet_committer_cli enables — i.e. it is in a shipped binary.
  • 7 unlicensed: the stwo-circuits git crates declare no license. Fix is one line upstream (license = "Apache-2.0" in that repo's [workspace.package]); cargo-deny 0.20 cannot clarify them here without per-crate license files.

Because of those, the licenses step stays non-blocking (previous PR). [licenses.private] ignore is kept false with a comment: the workspace-only crates are now publish = false, and flipping it would silently drop all 99 from the license check.

🤖 Generated with Claude Code

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@cursor

cursor Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes only cargo-deny allowlist comments and one workspace manifest field; no runtime or security logic.

Overview
Expands cargo-deny [licenses].allow to cover SPDX identifiers already appearing in the dependency tree (e.g. ISC, MPL-2.0, Unicode-3.0, BSL-1.0, CDLA-Permissive-2.0, bzip2-1.0.6, Apache-2.0 WITH LLVM-exception), with a short note that these are permissive or file-level weak copyleft only. Documents why [licenses.private] ignore stays false: internal publish = false crates should still be license-checked.

bench_tools now sets license.workspace = true, aligning it with other workspace members and clearing its unlicensed manifest finding.

This is policy/config only; known failures (e.g. GPL rhexdump on a shipped path, git stwo-circuits crates with no license) are intentionally unchanged and need separate decisions.

Reviewed by Cursor Bugbot for commit c0f4a93. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label Oct 15, 2026
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from b8f0246 to e3a6bd8 Compare October 18, 2026 10:15
@avi-starkware
avi-starkware removed this pull request from stack #15116 October 18, 2026 10:16
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from e3a6bd8 to 88000a9 Compare October 25, 2026 12:31
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch 2 times, most recently from 3a67514 to fd25779 Compare October 29, 2026 08:41
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch 2 times, most recently from e0480eb to 5eecb12 Compare October 29, 2026 10:06
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from 5eecb12 to 249d6ce Compare October 29, 2026 10:53
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from 249d6ce to dfe663c Compare October 29, 2026 12:19
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from dfe663c to 3c7b961 Compare October 29, 2026 13:55
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from 3c7b961 to 50a9346 Compare October 29, 2026 14:10
…dency tree

Unicode-3.0, ISC, CDLA-Permissive-2.0, BSL-1.0, bzip2-1.0.6, Apache-2.0 WITH LLVM-exception are
permissive, and MPL-2.0 is file-level weak copyleft, so allowing them drops the
license rejections from 41 to one without changing what the workspace may be distributed under.
bench_tools was the only workspace member that did not inherit the workspace license field, so it
now does. The one remaining rejection is rhexdump, which is GPL-3.0-or-later and reaches the
starknet_committer_cli binary through aerospike, so it stays rejected pending a licensing decision
and the licenses step stays non-blocking.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@avi-starkware
avi-starkware force-pushed the avi/deps/05-license-allowlist branch from 50a9346 to c0f4a93 Compare October 29, 2026 16:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants