fix(ui-tests): Update scanner e2e tests to default to v4 - #22648
Conversation
|
Skipping CI for Draft Pull Request. |
🚀 Build Images ReadyImages are ready for commit eb7607c. To use with deploy scripts: export MAIN_IMAGE_TAG=5.0.x-225-geb7607cea5 |
|
/test gke-ui-e2e-tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mc/remove-scanner-v2-installation #22648 +/- ##
=====================================================================
- Coverage 51.46% 51.39% -0.07%
=====================================================================
Files 2886 2880 -6
Lines 181300 180756 -544
=====================================================================
- Hits 93299 92895 -404
+ Misses 79837 79731 -106
+ Partials 8164 8130 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dvail
changed the title
|
|
||
| export function interactAndWaitForScannerCertificateDownload(interactionCallback) { | ||
| interactAndWaitForCertificateDownload('scanner', interactionCallback); | ||
| export function interactAndWaitForScannerV4CertificateDownload(interactionCallback) { |
There was a problem hiding this comment.
Was the renaming by human or agent? Versus just change implementation.
Not requesting change, but out of curiosity.
There was a problem hiding this comment.
This was an agent. I debated on reverting and leaving it as just "Scanner". (Without both v2 and v4 coexisting, is there value in calling out the version in this way?)
I didn't feel strongly enough to change it, but if you think the original is better with only an implementation change it will be quick to undo.
|
|
||
| const statusSelector = | ||
| 'div:has(.pf-v6-c-card__header:contains("StackRox Scanner Vulnerability Definitions"))'; | ||
| const statusSelector = 'div:has(.pf-v6-c-card__header:contains("Scanner V4 Vulnerabilities"))'; |
There was a problem hiding this comment.
Change like this is what I expected elsewhere.
2 participants
Description
Fixes UI e2e tests to handle full removal of Scanner V2.
scannerSCANNER_V4instead ofSCANNERNote
There is one set of test failures that is not fixed by this change - Legacy Platform CVE page tests. This needs to be fixed in
masterin the same way the new "Kubernetes Components" page removal was so will not be included in this PR. The change should be picked up either during a rebase, or a separate PR targeting the scanner-v2 removal branch. #22649User-facing documentation
Testing and quality
Automated testing
How I validated my change
Local Cypress test runs
CI (TBD)