Repository navigation
Conversation
Author
|
@un-lock-able Could you please review this PR? Thanks! |
un-lock-able
self-requested a review
September 17, 2026 07:36
un-lock-able
left a comment
un-lock-able
left a comment
There was a problem hiding this comment.
This PR may need more discussion before merging.
|
|
||
| ```md | ||
| DEFAULT <- `$CONFIG_DIR`/mitosis/config.toml <- config file specified by `cli.config` or loal `config.toml` <- env prefixed by `MITO_` <- cli arguments | ||
| DEFAULT <- `$CONFIG_DIR`/mitosis/config.toml <- config file specified by the root-level `--config` option or loal `config.toml` <- env prefixed by `MITO_` <- cli arguments |
| This command: | ||
|
|
||
| - Lists all currently running `mito worker` processes | ||
| - Lists all currently running worker processes, including those started with the root-level `--config` option |
There was a problem hiding this comment.
No need to mention the global --config option here.
| use crate::config::{manager::ManagerCommand, ManagerConfigCli, WorkerConfigCli}; | ||
| use crate::error; | ||
|
|
||
| const WORKER_PROCESS_PATTERN: &str = r"mito( --config(=[^ ]+| [^ ]+))? worker( |$)"; |
There was a problem hiding this comment.
This may need some more discussion. Will this match command like bash mito ...?
|
Making |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--configa global CLI option shared by all runtime modes--configto be specified at different subcommand levels--config