Repository navigation
test(stats): pin the relay client's clock to the fake gateway's - #1825
Merged
Merged
Conversation
The fake gateway's clock is fixed at 24 Oct 2026, but the client stamped each report with the real day, so from 25 Oct the gateway judged every test report stale and answered 400. statsrelaytest now gives the client the gateway's clock. Production is unchanged: box and gateway both read the real time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frahlg
added
the
no-changeset
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 25 Oct 2026 every PR fails
core (Go)in two tests from #1820:internal/statsrelayTestAReportReachesTheGatewayThroughTheRelay:statsrelay: gateway answered 400internal/energyreportTestABoxReportReachesTheGatewayThroughTheRelay:gateway got []Master was green on 24 Oct, the day #1820 merged.
Cause
statsrelaytest.Newgives the fake gateway a fixed clock (24 Oct in the statsrelay test, a fixed day in the energyreport test), but the client it returns stamps each report withtime.Now(). From 25 Oct the gateway's freshness check (reportwire.Fresh) rejects the day, so it answers 400.Production is unaffected: the box and the gateway both read the real clock.
Change
statsrelay.Client.WithClocksets the clock the client stamps reports with.statsrelaytest.Newreturns a client on the gateway's clock.No behaviour change in Core. Labelled
no-changeset(test-only; the new method is used only by the test helper).Evidence
go test ./internal/statsrelay/... ./internal/energyreport/fails on master today and passes here;go vetclean.🤖 Generated with Claude Code