Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ending battery discharge raises import just as adding charge does. The shared fuse allocator accounts for pending rises when increasing positive charge, but did not subtract them when deciding how much existing relief may end. Successive commands can therefore spend the same measured phase room twice. The mirrored export pass has the same problem when ending battery charge.
Stacked on #1789, targeting
fix/fuse-one-functionatc60da23df78a0355f496fb3e3691898e19c7d7cc. This is a narrow follow-up to that implementation, not a merge of #1763's different EV-reservation policy. Retarget after #1789 lands; do not merge independently into master.Change
Include
pendingWincapBatteryCharge's relief shortfall, as it is already included in positive charging-rise room. Import and export use the same function with reversed signs. Existing relief availability, battery floor/direction bounds and the no-new-relief condition are retained. No additional telemetry, settings, timing changes or driver behavior.Reproduced case
(24−22.3)×690 = 1,173 W.The symmetric export case retains +827 W rather than ending charge into excessive export. These are balanced-response calculations assuming unchanged other loads and that the target arrives before another correction; they are not hardware measurements or evidence of fuse operation.
Validation
ComputeDispatchwith bounded manual zero target, and ordinary idle dispatch.c2246d10d6dcbbb6df2fdf6d328b6b784b61c1f5:make verifypasses; fullgo test -race ./internal/control ./internal/telemetry ./internal/loadpoint -count=1passes; telemetry-read ratchet andgit diff --checkpass.This addresses the independent pending-battery regression found while comparing #1763 and #1789. It does not resolve the separate EV-under-delivery reservation-policy decision, establish hardware acceptance or change the running household installation.