Repository navigation
fix(live): one Home use; the page follows load_quality alone - #1773
Merged
Merged
Conversation
/api/status always sent load_estimate, an energy-averaged Home use, and the energy flow treated its presence as "estimated". Every box therefore showed "≈" on Home use and never showed "% self-powered now", even with every device read. The page now reads Core's load_quality only. HomeUseEstimate came in on 18 October as the live Home use and was left behind when #1768 made Home use the plain balance. It fed only load_estimate and a second Home Assistant sensor that has not shipped. Remove it, its observation buffers in the telemetry store and the HA sensor, so Core has one Home use value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 18 October every box shows Home use on the energy flow as an estimate ("≈ 614 W") and never shows "% self-powered now", even when every device is read.
/api/statusalways carriesload_estimate, an energy-averaged Home use object, andweb/components/energy-flow-readings.js:211treated its presence as "estimated".Seen on the home box (v0.154.1-beta.1):
history_quality: complete, every flow read, page shows "≈ 614 W" and no self-powered line.Change
load_quality: "estimated"./api/statusno longer sendsload_estimate.HomeUseEstimate(telemetry/home_estimate.go, home_energy.go), its observation buffers in the telemetry store and the Home Assistant sensor "Load Power (energy average)" are removed. They came in on 18 October as the live Home use and were left behind when fix(live): Home use as the plain balance; display and energy load as two series #1768 made Home use the plain balance; after fix(live): Home use as the plain balance; display and energy load as two series #1768 they fed onlyload_estimateand the HA sensor, which has not shipped. Core now has one Home use value.+28 / −1,240.
Evidence
make verify: 77 Go packages pass, build and vet clean.npm test: 868/868.measured/unknownquality, noload_estimate); the page marks estimated only onload_quality: "estimated"; HA publishes "Load Power" and no energy-average sensor.🤖 Generated with Claude Code