Repository navigation
Conversation
Core is the primitive for energy control, chargers included: it reads, protects the fuse by physics, acts within limits and records. Forecasts, the Energy Planner and analysis are layers that read three separate streams and never complicate the core or hold up its control loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1455c0bcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Training data:** only the intervals that history marks as fully | ||
| measured. Models learn from these and nothing else. |
There was a problem hiding this comment.
Scope the fully measured restriction to forecast training
The absolute “nothing else” restriction conflicts with the battery/inverter twin requirements later in this file: VISION.md:190-193 explicitly permits quality-labeled device-only samples, and the existing battery model learns from commanded and device-reported power on each control tick (go/cmd/ftw/main.go:2959), not from fully measured history intervals. Following this new requirement would discard valid response and saturation learning whenever independent site confirmation is unavailable; limit it to household/PV forecast training or preserve the documented device-only tier.
Useful? React with 👍 / 👎.
Fredrik asked that VISION.md say what FTW is building: a hard, simple core that people, automations and AI agents can build on, chargers included, with forecasting and planning as layers that do not complicate it.
Change
Why now
A review of master on 21 October found nine separate fuse-limit calculations, several confirmed false limits (export counted as import, phase mode decided two ways, the hourly ceiling reported as the fuse) and one path where a slow cloud charger can exceed the fuse. It also found forecast and history logic on the control tick. Each line above answers one of those findings.
#1292 also edits VISION.md, in a different section.
🤖 Generated with Claude Code