Repository navigation
fix(backup): bind extraction stages to their restore operation - #1581
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A complete safety point from an earlier restore must not turn a later extraction-only interruption into evidence of partial activation. Record each stage as extracting when it is created, then bind it to its own safety point before the first active-file move. Retry can accept extraction-only stages while still refusing preservation, interrupted revert, unknown records and ambiguous older stages.
Retain abandoned extraction copies after success. Record reads and writes reject links and unknown forms before changing data.
The repeated-restore regression fails on the prior implementation and passes after this fix. Real subprocess SIGKILL tests cover preservation, activation and revert and now check the stage/point binding. Tests also cover malformed and linked stage records, retained source bytes and normal return in both directions. Full
make verifyruns before handoff.This addresses the P2 finding on #1580. Holds #1554 and #1556 remain. The known helper gaps require a new exact beta and a fresh 48-hour trial; no stable promotion or general migration claim follows from these source tests. The release scope is the approved Home Assistant migration capability plus these backup fixes, with Energyplan and the driver pin unchanged.