Repository navigation
test(escrow): give the read-timing test a minute on a busy runner - #102
Merged
Merged
Conversation
It makes 800 timed reads on purpose and took 5.1 s on CI on 23 October 2026, past vitest's 5 s default, so it failed before measuring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
escrow/src/cost.test.ts"takes the same time to read an empty bucket as a full one" makes 800 timed reads on purpose. On 23 October 2026 it took 5.1 s on CI, three runs in a row on #101, and vitest's 5 s default timeout ended it before it measured anything.Change
The test gets a 60 s timeout. Its assertion and bound are unchanged.
Tests
CI on this PR.
🤖 Generated with Claude Code