Repository navigation
Conversation
- GetFriendList was requested over plain http, sending the Steam Web API key in clear text. - Bump version 1.5.5 -> 1.5.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WareZ57
left a comment
There was a problem hiding this comment.
LGTM.
One-line change: the GetFriendList request now goes to https://api.steampowered.com/... instead of http://, so the Steam Web API key no longer travels in clear text. ripext validates against its bundled ca-bundle.crt, which is already used for the other HTTPS calls, so no extra setup is needed. The request still fits in sRequest[256] (32-char key + 17-digit SteamID64). Version bump to 1.5.6 is fine.
Checked: read the diff and the surrounding code, CI build is green, and the HTTPS endpoint answers (HTTP 400 without a key, so the route exists over TLS).
Not tested: no runtime test on a game server, so @friends / @!friends with a real API key were not exercised.
Agree with rotating the key, since it has been sent over plain HTTP until now.
Summary
GetFriendList(used by@friends/@!friends) was requested over plainhttp://, with the API key in thekey=query parameter. It now useshttps://, like RelayHelper's Steam Web API call.configs/ripext/ca-bundle.crt, which ships with the extension and is already used by every Discord webhook.Since the key has been sent over plain HTTP until now, consider rotating it.
Test plan
@friends/@!friendsstill target the right players after they join🤖 Generated with Claude Code