Conversation
81reap
added this pull request to stack #1502
September 25, 2026 22:42
lovasoa
force-pushed
the
81reap/ci-1474
branch
from
September 26, 2026 12:32
216a12e to
ce2d346
Compare
81reap
force-pushed
the
81reap/ci-1474
branch
2 times, most recently
from
September 26, 2026 14:56
4159106 to
50d8484
Compare
81reap
force-pushed
the
81reap/ci-1474
branch
from
September 27, 2026 23:26
50d8484 to
0044783
Compare
Before a bound parameter had to survive a round trip in `tests/transactions` and in `computed_projection_binding_order.sql`, but nothing bound one variable twice in a single statement, and nothing asserted that a parameterized page runs as a prepared statement rather than through `SQLExecDirect`. Now two tests cover both halves of [sqlx-oldapi#57](sqlpage/sqlx-oldapi#57), one of wich covers the `INSERT ... SELECT $x WHERE $x IS NOT NULL` shape from #1474.
lovasoa
force-pushed
the
81reap/ci-1474
branch
from
September 28, 2026 07:21
0044783 to
2f4a1d6
Compare
lovasoa
requested changes
Sep 28, 2026
| SupportedDatabase::Mssql => "/tests/parameter_binding/parameter_in_projection_mssql.sql", | ||
| SupportedDatabase::Oracle => return Ok(()), // no CREATE TEMPORARY TABLE | ||
| _ => "/tests/parameter_binding/parameter_in_projection.sql", | ||
| }; |
Collaborator
There was a problem hiding this comment.
is there a reason we can't use the fully sql-based testing mechanism here ? do we need rust at all for these tests ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before a bound parameter had to survive a round trip in
tests/transactionsand incomputed_projection_binding_order.sql, but nothing bound one variable twice in a single statement, and nothing asserted that a parameterized page runs as a prepared statement rather than throughSQLExecDirect.Now two tests cover both halves of sqlx-oldapi#57, one of wich covers the
INSERT ... SELECT $x WHERE $x IS NOT NULLshape from #1474.Stack created with GitHub Stacks CLI • Give Feedback 💬