fix(ci) :: refactor image build step to include amd64 - #1485
Merged
Merged
Conversation
81reap
added this pull request to stack #1492
September 24, 2026 05:42
81reap
force-pushed
the
81reap/docker-amd64
branch
from
September 24, 2026 05:43
3834cd4 to
f4f8d45
Compare
lovasoa
approved these changes
Sep 24, 2026
Collaborator
Looks like the ci changes don't build the image the tests need anymore ? |
`docker_build_amd64_minimal` was a copy of `docker_build` but for amd64 as it does a few extra things (1) doesn't need QEMU, (2) builds a tarball for Hurl testing, and (3) some extra cache scope. Now it joins the `docker_build` matrix with the flag `export: true` to gate the extra steps needed for amd64. This cleans up the CI and makes upgrading other platforms to also export a feature flag change rather than a CI refactor.
81reap
force-pushed
the
81reap/docker-amd64
branch
from
September 24, 2026 13:23
f4f8d45 to
b9935af
Compare
Collaborator
Author
|
actually I think that's just a transient failure in the CI. rebasing on mainline seems to have fixed it edit :: missed including the CI link https://github.com/sqlpage/SQLPage/actions/runs/36005310697 |
Collaborator
|
@81reap I think this wasn't a transient failure and it broke ci on main. |
Collaborator
|
You removed the dependency of the hurl tests on the job that creates the docker image they use ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker_build_amd64_minimalwas a copy ofdocker_buildbut for amd64 as it does a few extra things (1) doesn't need QEMU, (2) builds a tarball for Hurl testing, and (3) some extra cache scope.Now it joins the
docker_buildmatrix with the flagexport: trueto gate the extra steps needed for amd64. This cleans up the CI and makes upgrading other platforms to also export a feature flag change rather than a CI refactor.Stack created with GitHub Stacks CLI • Give Feedback 💬