Skip to content

fix(ci) :: refactor image build step to include amd64 - #1485

Merged
81reap merged 1 commit into
mainfrom
81reap/docker-amd64
Sep 24, 2026
Merged

81reap merged 1 commit into
mainfrom
81reap/docker-amd64

Conversation

@81reap

@81reap 81reap commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

docker_build_amd64_minimal was a copy of docker_build but for amd64 as it does a few extra things (1) doesn't need QEMU, (2) builds a tarball for Hurl testing, and (3) some extra cache scope.

Now it joins the docker_build matrix with the flag export: true to gate the extra steps needed for amd64. This cleans up the CI and makes upgrading other platforms to also export a feature flag change rather than a CI refactor.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@81reap
81reap added this pull request to stack #1492 September 24, 2026 05:42
@81reap
81reap force-pushed the 81reap/docker-amd64 branch from 3834cd4 to f4f8d45 Compare September 24, 2026 05:43
Base automatically changed from 81reap/prefetch-script to main September 24, 2026 06:45
@lovasoa

lovasoa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Run actions/download-artifact@v8
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: sqlpage-linux-amd64-minimal-image
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

Looks like the ci changes don't build the image the tests need anymore ?

`docker_build_amd64_minimal` was a copy of `docker_build` but for amd64 as it does a few extra things (1) doesn't need QEMU, (2) builds a tarball for Hurl testing, and (3) some extra cache scope.

Now it joins the `docker_build` matrix with the flag `export: true` to gate the extra steps needed for amd64. This cleans up the CI and makes upgrading other platforms to also export a feature flag change rather than a CI refactor.
@81reap
81reap force-pushed the 81reap/docker-amd64 branch from f4f8d45 to b9935af Compare September 24, 2026 13:23
@81reap

81reap commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

actually I think that's just a transient failure in the CI. rebasing on mainline seems to have fixed it

edit :: missed including the CI link https://github.com/sqlpage/SQLPage/actions/runs/36005310697

@81reap
81reap merged commit 4bbc429 into main Sep 24, 2026
52 checks passed
@lovasoa
lovasoa deleted the 81reap/docker-amd64 branch September 24, 2026 14:50
@lovasoa

lovasoa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

@81reap I think this wasn't a transient failure and it broke ci on main.

@lovasoa

lovasoa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

You removed the dependency of the hurl tests on the job that creates the docker image they use !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants