Repository navigation
ci: use matrix.os for runs-on to test across operating systems - #708
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Fixes spotify#695 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
.github/workflows/ci.ymlso that unit tests are properly executed across Ubuntu, macOS, and Windows runners instead of repeating tests exclusively on Ubuntu 22.04.Problem
In
.github/workflows/ci.yml,runs-onwas hardcoded toubuntu-22.04rather than referencing${{ matrix.os }}. Additionally, theubuntu-20.04matrix entry used a deprecated GitHub Actions runner image.Solution
runs-on: ${{ matrix.os }}to dynamically evaluate the operating system axis.ubuntu-20.04toubuntu-latestin theosmatrix.Testing
Fixes #695