Repository navigation
fix: fallback to decimal for integer strings with leading zeros - #362
Open
wwww-deeeee wants to merge 1 commit into
Open
wwww-deeeee wants to merge 1 commit into
wwww-deeeee wants to merge 1 commit into
Conversation
When parsing integer strings with leading zeros (e.g. '08', '09', '-08'), strconv.ParseInt with base 0 treats them as octal numbers, which fails due to digits 8 and 9 being invalid in base 8. This change adds a fallback to base 10 when base 0 parsing fails, allowing common business decimal values like months or dates with leading zeros to be parsed correctly while preserving support for 0x, 0b, and valid octal numbers. Closes spf13#147 Signed-off-by: wwww-deeeee <192517353+wwww-deeeee@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing integer strings with leading zeros (e.g. '08', '09', '-08'), strconv.ParseInt with base 0 treats them as octal numbers, which fails due to digits 8 and 9 being invalid in base 8.
This change adds a fallback to base 10 when base 0 parsing fails, allowing common business decimal values like months or dates with leading zeros to be parsed correctly while preserving support for 0x, 0b, and valid octal numbers.
Closes #147