Skip to content

More Decimal fixes (NaN payloads, mixed storage divisible_by) - #2776

Merged
jviotti merged 2 commits into
mainfrom
decimal-fixes-3
Aug 31, 2026
Merged

More Decimal fixes (NaN payloads, mixed storage divisible_by)#2776
jviotti merged 2 commits into
mainfrom
decimal-fixes-3

Conversation

@jviotti

@jviotti jviotti commented Aug 31, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 3175371 Previous: 389a44f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.0226207756828227 ns/iter 1.4016401573136243 ns/iter 1.44
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.022906884314601 ns/iter 1.4000972169020565 ns/iter 1.44
Regex_Period_Asterisk 2.0226220485496933 ns/iter 1.40176181569588 ns/iter 1.44
Regex_Group_Period_Asterisk_Group 2.0180336364819254 ns/iter 1.4120069649158495 ns/iter 1.43
Regex_Period_Plus 2.184960785468481 ns/iter 2.2212523381747507 ns/iter 0.98
Regex_Period 2.212457027473884 ns/iter 2.2109752057253047 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.22791096113305 ns/iter 2.1896081060955135 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 2.252430145161854 ns/iter 2.1846654377587567 ns/iter 1.03
Regex_Caret_Period_Asterisk_Dollar 2.018956939411332 ns/iter 1.4875862239698716 ns/iter 1.36
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.0234935472069298 ns/iter 1.3992591584017504 ns/iter 1.45
Regex_Caret_X_Hyphen 3.756363926168443 ns/iter 3.8691059126366834 ns/iter 0.97
Regex_Period_Md_Dollar 26.071308472771623 ns/iter 18.70988331549712 ns/iter 1.39
Regex_Caret_Slash_Period_Asterisk 3.7614923257687933 ns/iter 3.9754357495818793 ns/iter 0.95
Regex_Caret_Period_Range_Dollar 2.3321064025474003 ns/iter 2.483758281302877 ns/iter 0.94
Regex_Nested_Backtrack 36.24939573678598 ns/iter 29.777316898673455 ns/iter 1.22
JSON_Array_Of_Objects_Unique 362.880372307096 ns/iter 357.9942691529707 ns/iter 1.01
JSON_Parse_1 4247.584887567504 ns/iter 3627.403652916481 ns/iter 1.17
JSON_Parse_Real 4540.851872993668 ns/iter 3981.4623108689484 ns/iter 1.14
JSON_Parse_Decimal 7221.711121514901 ns/iter 6131.520565981343 ns/iter 1.18
JSON_Parse_Schema_ISO_Language 3162750.18433222 ns/iter 2765689.34586461 ns/iter 1.14
JSON_Parse_Integer 3512.5935947322964 ns/iter 2738.9871063830574 ns/iter 1.28
JSON_Parse_String_NonSSO_Plain 2781.320261229865 ns/iter 2229.0568771063945 ns/iter 1.25
JSON_Parse_String_SSO_Plain 2274.5181283788665 ns/iter 2087.152918572732 ns/iter 1.09
JSON_Parse_String_Escape_Heavy 14846.955343747022 ns/iter 11194.363462096073 ns/iter 1.33
JSON_Parse_Object_Short_Keys 7009.86544115529 ns/iter 6132.923649906803 ns/iter 1.14
JSON_Parse_Object_Scalar_Properties 3637.9098617473596 ns/iter 3168.202575678086 ns/iter 1.15
JSON_Parse_Object_Array_Properties 4933.685664890898 ns/iter 4202.978844053981 ns/iter 1.17
JSON_Parse_Object_Object_Properties 4829.8921036806005 ns/iter 4127.122946124947 ns/iter 1.17
JSON_Parse_Nested_Containers 32203.630951291056 ns/iter 27593.513551215463 ns/iter 1.17
JSON_From_String_Copy 8.991968072864019 ns/iter 7.147895541721439 ns/iter 1.26
JSON_From_String_Temporary 8.801713446759532 ns/iter 6.511615044407238 ns/iter 1.35
JSON_Number_To_Double 22.251222471198915 ns/iter 20.008242892535097 ns/iter 1.11
JSON_Object_At_Last_Key/8 4.697773570388327 ns/iter 3.6578754399736266 ns/iter 1.28
JSON_Object_At_Last_Key/32 17.975066744236397 ns/iter 11.83786346855067 ns/iter 1.52
JSON_Object_At_Last_Key/128 73.90619742464892 ns/iter 43.723767365686676 ns/iter 1.69
JSON_Object_At_Last_Key/512 304.3255499390849 ns/iter 182.71970813466 ns/iter 1.67
JSON_Fast_Hash_Helm_Chart_Lock 44.09818907935048 ns/iter 46.34703543739862 ns/iter 0.95
JSON_Equality_Helm_Chart_Lock 128.08544941297757 ns/iter 117.10069225365987 ns/iter 1.09
JSON_Divisible_By_Decimal 257.85579232814206 ns/iter 207.96570583073014 ns/iter 1.24
JSON_String_Equal/10 4.32176350153298 ns/iter 4.451677808809734 ns/iter 0.97
JSON_String_Equal/100 5.480776783279498 ns/iter 5.646631861199583 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 0.8645248409097199 ns/iter 0.5868708159640602 ns/iter 1.47
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 9.80908492832229 ns/iter 8.730570465944524 ns/iter 1.12
JSON_String_Fast_Hash/10 1.7345527666726825 ns/iter 1.6895651445330302 ns/iter 1.03
JSON_String_Fast_Hash/100 1.7319765605170607 ns/iter 1.7005275057720426 ns/iter 1.02
JSON_String_Key_Hash/10 1.729430457960581 ns/iter 1.6878640089798052 ns/iter 1.02
JSON_String_Key_Hash/100 6.626279381262517 ns/iter 5.920571985212282 ns/iter 1.12
JSON_Object_Defines_Miss_Same_Length 3.7889262162425688 ns/iter 3.9599303235256076 ns/iter 0.96
JSON_Object_Defines_Miss_Too_Small 3.4588982952652683 ns/iter 3.854231876589175 ns/iter 0.90
JSON_Object_Defines_Miss_Too_Large 3.477500296693874 ns/iter 3.265867800975292 ns/iter 1.06
Pointer_Object_Traverse 29.761826755154576 ns/iter 20.234877010994442 ns/iter 1.47
Pointer_Object_Try_Traverse 38.583168976681286 ns/iter 23.568229427034264 ns/iter 1.64
Pointer_Push_Back_Pointer_To_Weak_Pointer 135.42438559627257 ns/iter 116.94136140612025 ns/iter 1.16
Pointer_Walker_Schema_ISO_Language 1885734.948509683 ns/iter 1757623.7645569914 ns/iter 1.07
Pointer_Maybe_Tracked_Deeply_Nested/0 1099372.5416012548 ns/iter 934567.561752995 ns/iter 1.18
Pointer_Maybe_Tracked_Deeply_Nested/1 1880371.7297296808 ns/iter 1395631.7777777754 ns/iter 1.35
Pointer_Position_Tracker_Get_Deeply_Nested 696.3708179828424 ns/iter 578.4764013327182 ns/iter 1.20
JSONPath_Descendant_Filter_Nested 1384.5022702089802 ns/iter 1067.094831599443 ns/iter 1.30
URITemplateRouter_Create 19919.9541751228 ns/iter 16538.27563005553 ns/iter 1.20
URITemplateRouter_Match 161.2983319835879 ns/iter 146.5518581854418 ns/iter 1.10
URITemplateRouter_Match_BasePath 182.3558647553786 ns/iter 162.819034300351 ns/iter 1.12
URITemplateRouterView_Restore 3741.512879624958 ns/iter 2865.1352961506227 ns/iter 1.31
URITemplateRouterView_Match 126.77331410004979 ns/iter 116.45481962413541 ns/iter 1.09
URITemplateRouterView_Match_BasePath 140.5612160594175 ns/iter 129.98416707218783 ns/iter 1.08
URITemplateRouterView_Arguments 422.2975417984532 ns/iter 376.94059249343906 ns/iter 1.12
JSONL_Parse_Large 8268954.529412173 ns/iter 7289096.43750016 ns/iter 1.13
JSONL_Parse_Large_GZIP 9732029.847222002 ns/iter 8647212.901234489 ns/iter 1.13
JSONLD_Catalog_Annotation_List_Populate 657767.3568075062 ns/iter 599253.5682403501 ns/iter 1.10
JSONLD_Catalog_Materialize 3436462.328431398 ns/iter 2864444.5142856743 ns/iter 1.20
HTML_Build_Table_100000 59425807.2222197 ns/iter 46246683.00000033 ns/iter 1.28
HTML_Render_Table_100000 3070331.509009209 ns/iter 2727500.1750972667 ns/iter 1.13
GZIP_Compress_ISO_Language_Set_3_Locations 31464210.863635924 ns/iter 23755817.241379872 ns/iter 1.32
GZIP_Decompress_ISO_Language_Set_3_Locations 5035550.823529721 ns/iter 3122726.4196428247 ns/iter 1.61
GZIP_Compress_ISO_Language_Set_3_Schema 1905336.0896739825 ns/iter 1602554.0549198522 ns/iter 1.19
GZIP_Decompress_ISO_Language_Set_3_Schema 348797.6919642402 ns/iter 303669.90329575975 ns/iter 1.15
JOSE_VerifySignature_RS256 49106.139613119034 ns/iter 41046.18426452472 ns/iter 1.20
JOSE_VerifySignature_ES512 2111558.761329272 ns/iter 1787289.2295918472 ns/iter 1.18

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 3175371 Previous: 389a44f Ratio
JOSE_VerifySignature_RS256 21949.408330389542 ns/iter 18964.24240591555 ns/iter 1.16
JOSE_VerifySignature_ES512 493296.5368420969 ns/iter 424069.45443571464 ns/iter 1.16
GZIP_Compress_ISO_Language_Set_3_Locations 28204829.800000653 ns/iter 24166485.9310343 ns/iter 1.17
GZIP_Decompress_ISO_Language_Set_3_Locations 4278828.355263299 ns/iter 3196604.3669724525 ns/iter 1.34
GZIP_Compress_ISO_Language_Set_3_Schema 1854771.094086027 ns/iter 1597359.1643835928 ns/iter 1.16
GZIP_Decompress_ISO_Language_Set_3_Schema 350441.7965087298 ns/iter 300715.2093224069 ns/iter 1.17
HTML_Build_Table_100000 56450098.3636368 ns/iter 49414520.91666558 ns/iter 1.14
HTML_Render_Table_100000 3857300.76719584 ns/iter 2733048.7047244445 ns/iter 1.41
JSONLD_Catalog_Annotation_List_Populate 722107.5418821147 ns/iter 633250.3551912372 ns/iter 1.14
JSONLD_Catalog_Materialize 3206534.6484017842 ns/iter 2743602.019455317 ns/iter 1.17
JSONL_Parse_Large 8753718.025000269 ns/iter 7563682.999999847 ns/iter 1.16
JSONL_Parse_Large_GZIP 10056523.492753398 ns/iter 8691403.012499776 ns/iter 1.16
URITemplateRouter_Create 16801.39325279317 ns/iter 14572.27714149138 ns/iter 1.15
URITemplateRouter_Match 151.59586124151903 ns/iter 135.9655392518058 ns/iter 1.11
URITemplateRouter_Match_BasePath 174.35862122949496 ns/iter 155.54047293477487 ns/iter 1.12
URITemplateRouterView_Restore 3632.7672442728117 ns/iter 3093.93027317731 ns/iter 1.17
URITemplateRouterView_Match 115.20711988658648 ns/iter 103.01419980041611 ns/iter 1.12
URITemplateRouterView_Match_BasePath 130.19353825642585 ns/iter 118.59903072677201 ns/iter 1.10
URITemplateRouterView_Arguments 445.75214905379846 ns/iter 387.788288256246 ns/iter 1.15
JSONPath_Descendant_Filter_Nested 1364.7076991449837 ns/iter 1137.7610948217234 ns/iter 1.20
Pointer_Object_Traverse 21.741052708488375 ns/iter 20.827133718021955 ns/iter 1.04
Pointer_Object_Try_Traverse 22.625791288178142 ns/iter 19.617700254380242 ns/iter 1.15
Pointer_Push_Back_Pointer_To_Weak_Pointer 106.0438654797808 ns/iter 108.42257544340612 ns/iter 0.98
Pointer_Walker_Schema_ISO_Language 1879968.7774799536 ns/iter 1686605.6328501957 ns/iter 1.11
Pointer_Maybe_Tracked_Deeply_Nested/0 1139550.4388254967 ns/iter 1003586.1759656892 ns/iter 1.14
Pointer_Maybe_Tracked_Deeply_Nested/1 1739585.2315270791 ns/iter 1497732.3163482232 ns/iter 1.16
Pointer_Position_Tracker_Get_Deeply_Nested 756.0550399693667 ns/iter 596.57458583511 ns/iter 1.27
JSON_Array_Of_Objects_Unique 423.8870472730915 ns/iter 356.5327641462695 ns/iter 1.19
JSON_Parse_1 4612.377471970548 ns/iter 3906.415027083155 ns/iter 1.18
JSON_Parse_Real 4908.378258314485 ns/iter 4267.37306825797 ns/iter 1.15
JSON_Parse_Decimal 7833.899705674894 ns/iter 6448.408053271428 ns/iter 1.21
JSON_Parse_Schema_ISO_Language 3334957.5072463998 ns/iter 2874053.1475409577 ns/iter 1.16
JSON_Parse_Integer 3154.9246269163064 ns/iter 2732.399900419806 ns/iter 1.15
JSON_Parse_String_NonSSO_Plain 2706.0224149643773 ns/iter 2350.5870372664876 ns/iter 1.15
JSON_Parse_String_SSO_Plain 2626.202456696432 ns/iter 2250.0619313811712 ns/iter 1.17
JSON_Parse_String_Escape_Heavy 16648.488528630383 ns/iter 14380.05552954598 ns/iter 1.16
JSON_Parse_Object_Short_Keys 7708.961980567733 ns/iter 6712.645027730716 ns/iter 1.15
JSON_Parse_Object_Scalar_Properties 3918.8250916922475 ns/iter 3404.919392976207 ns/iter 1.15
JSON_Parse_Object_Array_Properties 5818.101694208759 ns/iter 4895.795990244564 ns/iter 1.19
JSON_Parse_Object_Object_Properties 5881.204145624009 ns/iter 5002.607171847917 ns/iter 1.18
JSON_Parse_Nested_Containers 36735.91438588907 ns/iter 31202.941362421443 ns/iter 1.18
JSON_From_String_Copy 7.5668612618343145 ns/iter 7.1474785616597405 ns/iter 1.06
JSON_From_String_Temporary 5.676358562210915 ns/iter 5.189552211037279 ns/iter 1.09
JSON_Number_To_Double 24.127154753158386 ns/iter 19.448139093421137 ns/iter 1.24
JSON_Object_At_Last_Key/8 6.379522462799528 ns/iter 4.16712588289369 ns/iter 1.53
JSON_Object_At_Last_Key/32 21.376201778843875 ns/iter 11.441618681295418 ns/iter 1.87
JSON_Object_At_Last_Key/128 79.56705310577742 ns/iter 43.73402868399914 ns/iter 1.82
JSON_Object_At_Last_Key/512 227.68830221156065 ns/iter 181.41695740610243 ns/iter 1.26
JSON_Fast_Hash_Helm_Chart_Lock 74.9974644459879 ns/iter 66.51929205421831 ns/iter 1.13
JSON_Equality_Helm_Chart_Lock 131.3702810235175 ns/iter 117.79548856450424 ns/iter 1.12
JSON_Divisible_By_Decimal 255.69505073204812 ns/iter 217.8894541078953 ns/iter 1.17
JSON_String_Equal/10 5.061418228909047 ns/iter 4.700973589452898 ns/iter 1.08
JSON_String_Equal/100 6.381369576258567 ns/iter 5.758273275340381 ns/iter 1.11
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9427931029549415 ns/iter 0.8103535404219772 ns/iter 1.16
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 17.359480663486003 ns/iter 14.932979597012398 ns/iter 1.16
JSON_String_Fast_Hash/10 3.377235508479861 ns/iter 2.923632838876297 ns/iter 1.16
JSON_String_Fast_Hash/100 3.3736092809441227 ns/iter 2.9268052404846605 ns/iter 1.15
JSON_String_Key_Hash/10 1.3030510360545993 ns/iter 1.658563749226402 ns/iter 0.79
JSON_String_Key_Hash/100 13.043378449973714 ns/iter 11.271027570322353 ns/iter 1.16
JSON_Object_Defines_Miss_Same_Length 2.9926075873070155 ns/iter 2.5454607941002165 ns/iter 1.18
JSON_Object_Defines_Miss_Too_Small 3.0018744554125973 ns/iter 2.676662554225062 ns/iter 1.12
JSON_Object_Defines_Miss_Too_Large 3.011867379005363 ns/iter 2.588414525950934 ns/iter 1.16
Regex_Lower_S_Or_Upper_S_Asterisk 0.990096224454004 ns/iter 0.8444027978840121 ns/iter 1.17
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.9914073635851918 ns/iter 0.8458921501461633 ns/iter 1.17
Regex_Period_Asterisk 0.993530686852553 ns/iter 0.8454738671135656 ns/iter 1.18
Regex_Group_Period_Asterisk_Group 0.9944124117797947 ns/iter 0.8840333114012219 ns/iter 1.12
Regex_Period_Plus 0.9865377472922049 ns/iter 0.8443194688530224 ns/iter 1.17
Regex_Period 0.9834408396636946 ns/iter 0.8438846533750908 ns/iter 1.17
Regex_Caret_Period_Plus_Dollar 0.9853349231230613 ns/iter 0.8605308973303586 ns/iter 1.15
Regex_Caret_Group_Period_Plus_Group_Dollar 0.9873481785712225 ns/iter 0.8444141322703247 ns/iter 1.17
Regex_Caret_Period_Asterisk_Dollar 0.9846389092148472 ns/iter 0.8470304021862256 ns/iter 1.16
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.9861623858065213 ns/iter 0.843562540047387 ns/iter 1.17
Regex_Caret_X_Hyphen 3.612160665674856 ns/iter 2.9342017650945444 ns/iter 1.23
Regex_Period_Md_Dollar 17.698570156660335 ns/iter 15.181102508484486 ns/iter 1.17
Regex_Caret_Slash_Period_Asterisk 3.617657227829815 ns/iter 3.013613641109325 ns/iter 1.20
Regex_Caret_Period_Range_Dollar 1.6357913065205345 ns/iter 1.4098646327229236 ns/iter 1.16
Regex_Nested_Backtrack 35.68323631762978 ns/iter 30.066358373619707 ns/iter 1.19

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 3175371 Previous: 389a44f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 5.463163392856732 ns/iter 2.836917320162245 ns/iter 1.93
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.098242857142919 ns/iter 2.776815802331705 ns/iter 1.84
Regex_Period_Asterisk 5.076257142857087 ns/iter 2.8555670076538355 ns/iter 1.78
Regex_Group_Period_Asterisk_Group 5.108084821428756 ns/iter 2.8658724094348753 ns/iter 1.78
Regex_Period_Plus 5.0406049999998 ns/iter 2.8409183023030806 ns/iter 1.77
Regex_Period 4.986674999999536 ns/iter 2.846260043372113 ns/iter 1.75
Regex_Caret_Period_Plus_Dollar 4.753290893918241 ns/iter 2.7430959362755036 ns/iter 1.73
Regex_Caret_Group_Period_Plus_Group_Dollar 5.054973483271118 ns/iter 2.778708814483173 ns/iter 1.82
Regex_Caret_Period_Asterisk_Dollar 5.1818517857142865 ns/iter 2.733595064523421 ns/iter 1.90
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.060884999999757 ns/iter 2.8074013380324474 ns/iter 1.80
Regex_Caret_X_Hyphen 8.27751157018915 ns/iter 6.6038714285713445 ns/iter 1.25
Regex_Period_Md_Dollar 47.18789332867731 ns/iter 27.703739272157506 ns/iter 1.70
Regex_Caret_Slash_Period_Asterisk 8.172508928570974 ns/iter 6.070932142856732 ns/iter 1.35
Regex_Caret_Period_Range_Dollar 5.662949107142522 ns/iter 2.8415804451601288 ns/iter 1.99
Regex_Nested_Backtrack 59.41177678571766 ns/iter 37.605820312501336 ns/iter 1.58
JSON_Array_Of_Objects_Unique 575.3870000000347 ns/iter 507.45428571425623 ns/iter 1.13
JSON_Parse_1 9332.320312500007 ns/iter 7498.816071428597 ns/iter 1.24
JSON_Parse_Real 16152.758928571488 ns/iter 11380.19531250034 ns/iter 1.42
JSON_Parse_Decimal 12179.053571428662 ns/iter 8428.214606184481 ns/iter 1.45
JSON_Parse_Schema_ISO_Language 7661988.888889304 ns/iter 7913797.7777779475 ns/iter 0.97
JSON_Parse_Integer 6181.935714285507 ns/iter 4401.446761132366 ns/iter 1.40
JSON_Parse_String_NonSSO_Plain 8404.864263998843 ns/iter 6220.606250000316 ns/iter 1.35
JSON_Parse_String_SSO_Plain 3859.671500586502 ns/iter 2843.8922571909006 ns/iter 1.36
JSON_Parse_String_Escape_Heavy 22213.618749999496 ns/iter 22892.781330565245 ns/iter 0.97
JSON_Parse_Object_Short_Keys 13309.825625779346 ns/iter 9688.265230958445 ns/iter 1.37
JSON_Parse_Object_Scalar_Properties 6850.757142857386 ns/iter 5031.638000000385 ns/iter 1.36
JSON_Parse_Object_Array_Properties 11703.358928572121 ns/iter 9384.860937499796 ns/iter 1.25
JSON_Parse_Object_Object_Properties 12337.032812499872 ns/iter 9133.256994388403 ns/iter 1.35
JSON_Parse_Nested_Containers 80173.536895669 ns/iter 60490.62499999686 ns/iter 1.33
JSON_From_String_Copy 64.39289285714166 ns/iter 45.203309417825835 ns/iter 1.42
JSON_From_String_Temporary 59.48630357142549 ns/iter 55.47278999999889 ns/iter 1.07
JSON_Number_To_Double 123.29648437499509 ns/iter 89.26897321429118 ns/iter 1.38
JSON_Object_At_Last_Key/8 7.585310267857232 ns/iter 7.646762276785703 ns/iter 0.99
JSON_Object_At_Last_Key/32 23.295515365004935 ns/iter 18.050739611267158 ns/iter 1.29
JSON_Object_At_Last_Key/128 90.79133969681372 ns/iter 89.17732142856849 ns/iter 1.02
JSON_Object_At_Last_Key/512 428.4217231909192 ns/iter 309.60575892858037 ns/iter 1.38
JSON_Fast_Hash_Helm_Chart_Lock 102.15500000000155 ns/iter 81.96152312671713 ns/iter 1.25
JSON_Equality_Helm_Chart_Lock 212.68882256149894 ns/iter 203.33908467236608 ns/iter 1.05
JSON_Divisible_By_Decimal 309.3237946428573 ns/iter 253.7565714285555 ns/iter 1.22
JSON_String_Equal/10 10.412856250000324 ns/iter 8.761310267856791 ns/iter 1.19
JSON_String_Equal/100 11.748994642857724 ns/iter 12.093978571428465 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 2.5077208459752756 ns/iter 1.1736853571428747 ns/iter 2.14
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.341086096692111 ns/iter 9.802682099095806 ns/iter 1.46
JSON_String_Fast_Hash/10 6.667739955357504 ns/iter 3.9798024553570706 ns/iter 1.68
JSON_String_Fast_Hash/100 6.713648437499665 ns/iter 3.9298476562499296 ns/iter 1.71
JSON_String_Key_Hash/10 5.494417000000453 ns/iter 3.1270562499999346 ns/iter 1.76
JSON_String_Key_Hash/100 11.95052142857175 ns/iter 8.553561383928582 ns/iter 1.40
JSON_Object_Defines_Miss_Same_Length 4.743132166237325 ns/iter 4.597243761033768 ns/iter 1.03
JSON_Object_Defines_Miss_Too_Small 4.765415925799375 ns/iter 5.084684999999922 ns/iter 0.94
JSON_Object_Defines_Miss_Too_Large 4.785256974857528 ns/iter 4.922062367169996 ns/iter 0.97
Pointer_Object_Traverse 71.03226785714259 ns/iter 39.32457106238412 ns/iter 1.81
Pointer_Object_Try_Traverse 71.2002857142835 ns/iter 43.03864716036777 ns/iter 1.65
Pointer_Push_Back_Pointer_To_Weak_Pointer 181.09507462690433 ns/iter 132.24517043548255 ns/iter 1.37
Pointer_Walker_Schema_ISO_Language 10865154.687500045 ns/iter 9705602.666666286 ns/iter 1.12
Pointer_Maybe_Tracked_Deeply_Nested/0 2431076.4285715437 ns/iter 2017898.7499999579 ns/iter 1.20
Pointer_Maybe_Tracked_Deeply_Nested/1 3698816.042780689 ns/iter 3585666.666666699 ns/iter 1.03
Pointer_Position_Tracker_Get_Deeply_Nested 555.9083705357308 ns/iter 502.3900892857012 ns/iter 1.11
JSONPath_Descendant_Filter_Nested 2386.282142857153 ns/iter 1582.7011160714578 ns/iter 1.51
URITemplateRouter_Create 40564.20177183012 ns/iter 35171.25319190629 ns/iter 1.15
URITemplateRouter_Match 239.23226124641565 ns/iter 239.65567637771628 ns/iter 1.00
URITemplateRouter_Match_BasePath 268.60194725901016 ns/iter 269.5768272510443 ns/iter 1.00
URITemplateRouterView_Restore 33885.932592695644 ns/iter 17001.61563581963 ns/iter 1.99
URITemplateRouterView_Match 181.54383763784037 ns/iter 165.22774543936146 ns/iter 1.10
URITemplateRouterView_Match_BasePath 205.3175511018917 ns/iter 189.6207482312169 ns/iter 1.08
URITemplateRouterView_Arguments 533.7816071428643 ns/iter 443.5477499999862 ns/iter 1.20
JSONL_Parse_Large 32762609.52381043 ns/iter 25109489.285715166 ns/iter 1.30
JSONL_Parse_Large_GZIP 33378740.00000056 ns/iter 23327856.66666647 ns/iter 1.43
JSONLD_Catalog_Annotation_List_Populate 3203687.9464286524 ns/iter 2737771.4859439544 ns/iter 1.17
JSONLD_Catalog_Materialize 8037286.666667064 ns/iter 6600048.214285233 ns/iter 1.22
HTML_Build_Table_100000 91815128.57142998 ns/iter 94158428.57142869 ns/iter 0.98
HTML_Render_Table_100000 7717843.333333324 ns/iter 11997949.999999339 ns/iter 0.64
GZIP_Compress_ISO_Language_Set_3_Locations 36531984.21052725 ns/iter 29368462.50000021 ns/iter 1.24
GZIP_Decompress_ISO_Language_Set_3_Locations 10162254.66666659 ns/iter 11580331.250000242 ns/iter 0.88
GZIP_Compress_ISO_Language_Set_3_Schema 2130364.927536217 ns/iter 1861624.1286862297 ns/iter 1.14
GZIP_Decompress_ISO_Language_Set_3_Schema 636199.1071428414 ns/iter 678822.5000000239 ns/iter 0.94
JOSE_VerifySignature_RS256 21361.51394208924 ns/iter 18604.428065695658 ns/iter 1.15
JOSE_VerifySignature_ES512 1366787.1485943552 ns/iter 960134.5381526055 ns/iter 1.42

This comment was automatically generated by workflow using github-action-benchmark.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread test/numeric/decimal_ibm_dectest.cc Outdated
Comment thread src/core/json/json_value.cc

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 3175371 Previous: 389a44f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.801091079140327 ns/iter 1.6949384749406307 ns/iter 1.06
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.819287010990163 ns/iter 1.7142043234389708 ns/iter 1.06
Regex_Period_Asterisk 1.8793290873642288 ns/iter 1.8411391154364094 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 1.8707806675283138 ns/iter 1.8414627807444577 ns/iter 1.02
Regex_Period_Plus 2.2631183031787567 ns/iter 1.9496217447504496 ns/iter 1.16
Regex_Period 2.2970207022862543 ns/iter 1.9773546768519705 ns/iter 1.16
Regex_Caret_Period_Plus_Dollar 2.2074540258580977 ns/iter 2.037846059002111 ns/iter 1.08
Regex_Caret_Group_Period_Plus_Group_Dollar 2.141231719679806 ns/iter 2.0232781940306195 ns/iter 1.06
Regex_Caret_Period_Asterisk_Dollar 1.9517268733707278 ns/iter 1.6165943107337257 ns/iter 1.21
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.7974898275471822 ns/iter 1.6006525609239568 ns/iter 1.12
Regex_Caret_X_Hyphen 6.437103722464457 ns/iter 5.993323843134712 ns/iter 1.07
Regex_Period_Md_Dollar 19.435685495135676 ns/iter 17.292707849174484 ns/iter 1.12
Regex_Caret_Slash_Period_Asterisk 4.9038559201588425 ns/iter 4.827599359999027 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 2.296258904936962 ns/iter 2.0038724637324394 ns/iter 1.15
Regex_Nested_Backtrack 27.985375825313223 ns/iter 27.72156394327375 ns/iter 1.01
JSON_Array_Of_Objects_Unique 378.7900174628287 ns/iter 398.67812021153514 ns/iter 0.95
JSON_Parse_1 3635.1181637736986 ns/iter 3227.6138044476556 ns/iter 1.13
JSON_Parse_Real 5448.111234748086 ns/iter 5148.640419999992 ns/iter 1.06
JSON_Parse_Decimal 6527.978847947126 ns/iter 5436.879572887529 ns/iter 1.20
JSON_Parse_Schema_ISO_Language 2355693.5100669693 ns/iter 2405194.3870967035 ns/iter 0.98
JSON_Parse_Integer 3480.5465829872182 ns/iter 3410.7081353702515 ns/iter 1.02
JSON_Parse_String_NonSSO_Plain 3707.895014913843 ns/iter 3164.711585472759 ns/iter 1.17
JSON_Parse_String_SSO_Plain 1995.603549605367 ns/iter 1764.2363833141808 ns/iter 1.13
JSON_Parse_String_Escape_Heavy 18983.264150011044 ns/iter 17828.287870144068 ns/iter 1.06
JSON_Parse_Object_Short_Keys 5731.365565596981 ns/iter 5525.87147643862 ns/iter 1.04
JSON_Parse_Object_Scalar_Properties 2880.645678733318 ns/iter 2797.8808745432334 ns/iter 1.03
JSON_Parse_Object_Array_Properties 3867.124902140076 ns/iter 3504.850792394644 ns/iter 1.10
JSON_Parse_Object_Object_Properties 4384.387984233528 ns/iter 3517.4710077229847 ns/iter 1.25
JSON_Parse_Nested_Containers 27118.531227592783 ns/iter 26576.0682897875 ns/iter 1.02
JSON_From_String_Copy 12.107151701213542 ns/iter 11.687620955187603 ns/iter 1.04
JSON_From_String_Temporary 6.65390754588798 ns/iter 6.5652808564685055 ns/iter 1.01
JSON_Number_To_Double 36.87171606472091 ns/iter 34.95876740430864 ns/iter 1.05
JSON_Object_At_Last_Key/8 4.232019106985487 ns/iter 4.1058016382851585 ns/iter 1.03
JSON_Object_At_Last_Key/32 13.097737140434349 ns/iter 12.035144939842024 ns/iter 1.09
JSON_Object_At_Last_Key/128 57.38231799639023 ns/iter 56.82150311057221 ns/iter 1.01
JSON_Object_At_Last_Key/512 197.08738837258983 ns/iter 180.7508785951366 ns/iter 1.09
JSON_Fast_Hash_Helm_Chart_Lock 62.38266384654501 ns/iter 55.78308637807848 ns/iter 1.12
JSON_Equality_Helm_Chart_Lock 191.52648649062886 ns/iter 154.51674434471317 ns/iter 1.24
JSON_Divisible_By_Decimal 187.90025324506612 ns/iter 187.0103479300026 ns/iter 1.00
JSON_String_Equal/10 7.2854963675250595 ns/iter 7.573208088010461 ns/iter 0.96
JSON_String_Equal/100 6.924697323414467 ns/iter 6.9001713502392175 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.42453112003895344 ns/iter 0.3271200656924495 ns/iter 1.30
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.734547964281293 ns/iter 3.100442224808684 ns/iter 1.20
JSON_String_Fast_Hash/10 2.63123748143963 ns/iter 2.2967965327547177 ns/iter 1.15
JSON_String_Fast_Hash/100 2.1212333093851385 ns/iter 1.9526004523487275 ns/iter 1.09
JSON_String_Key_Hash/10 1.7524558313218157 ns/iter 1.5775252478486663 ns/iter 1.11
JSON_String_Key_Hash/100 2.240771847836947 ns/iter 2.160899675766783 ns/iter 1.04
JSON_Object_Defines_Miss_Same_Length 2.9787357705605007 ns/iter 2.566633617289547 ns/iter 1.16
JSON_Object_Defines_Miss_Too_Small 2.8514740426954117 ns/iter 2.6236823976892207 ns/iter 1.09
JSON_Object_Defines_Miss_Too_Large 2.8647027778498835 ns/iter 2.7582577681911795 ns/iter 1.04
Pointer_Object_Traverse 21.215542274208627 ns/iter 23.154775859052176 ns/iter 0.92
Pointer_Object_Try_Traverse 36.254913965792646 ns/iter 31.773364244341323 ns/iter 1.14
Pointer_Push_Back_Pointer_To_Weak_Pointer 159.69096859578698 ns/iter 140.40524446230484 ns/iter 1.14
Pointer_Walker_Schema_ISO_Language 1470386.9047619218 ns/iter 1427996.549494705 ns/iter 1.03
Pointer_Maybe_Tracked_Deeply_Nested/0 946677.6547770869 ns/iter 899196.9594594471 ns/iter 1.05
Pointer_Maybe_Tracked_Deeply_Nested/1 1142517.8282010346 ns/iter 1196150.2187501974 ns/iter 0.96
Pointer_Position_Tracker_Get_Deeply_Nested 365.76091521094884 ns/iter 343.6587915915708 ns/iter 1.06
JSONPath_Descendant_Filter_Nested 1467.9474079387678 ns/iter 1283.340983387598 ns/iter 1.14
URITemplateRouter_Create 19331.07346041429 ns/iter 18402.325801946037 ns/iter 1.05
URITemplateRouter_Match 178.16721854605964 ns/iter 168.72961184113188 ns/iter 1.06
URITemplateRouter_Match_BasePath 216.27683357375165 ns/iter 213.31887579705676 ns/iter 1.01
URITemplateRouterView_Restore 10781.164417142043 ns/iter 11080.832434771537 ns/iter 0.97
URITemplateRouterView_Match 146.8699117938799 ns/iter 143.00755429305622 ns/iter 1.03
URITemplateRouterView_Match_BasePath 165.03780148152578 ns/iter 169.84345183899592 ns/iter 0.97
URITemplateRouterView_Arguments 585.6674437951051 ns/iter 627.7114269427028 ns/iter 0.93
JSONL_Parse_Large 7231355.703703351 ns/iter 7386469.153846502 ns/iter 0.98
JSONL_Parse_Large_GZIP 7605748.697917155 ns/iter 9093188.85714152 ns/iter 0.84
JSONLD_Catalog_Annotation_List_Populate 492671.7753366419 ns/iter 572990.3826490873 ns/iter 0.86
JSONLD_Catalog_Materialize 2651496.897163105 ns/iter 2267485.9645392527 ns/iter 1.17
HTML_Build_Table_100000 39367842.21428573 ns/iter 39371358.833326064 ns/iter 1.00
HTML_Render_Table_100000 2089851.235294021 ns/iter 1742020.1795407317 ns/iter 1.20
GZIP_Compress_ISO_Language_Set_3_Locations 28185336.640001427 ns/iter 27349623.24999894 ns/iter 1.03
GZIP_Decompress_ISO_Language_Set_3_Locations 3737498.4385025 ns/iter 3330869.215310421 ns/iter 1.12
GZIP_Compress_ISO_Language_Set_3_Schema 1630170.6957547504 ns/iter 1770878.4476884047 ns/iter 0.92
GZIP_Decompress_ISO_Language_Set_3_Schema 296601.5656771043 ns/iter 319344.24721107865 ns/iter 0.93
JOSE_VerifySignature_RS256 26610.650033738722 ns/iter 20746.283742176893 ns/iter 1.28
JOSE_VerifySignature_ES512 1086947.172619072 ns/iter 1000523.8247694453 ns/iter 1.09

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 2984fe0 into main Aug 31, 2026
13 checks passed
@jviotti
jviotti deleted the decimal-fixes-3 branch August 31, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant