Skip to content

MPT-25021 Keep the E2E step on tests/e2e and raise the E2E job timeout to 180 minutes #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jentyk merged 1 commit into from
Sep 17, 2026
Merged

MPT-25021 Keep the E2E step on tests/e2e and raise the E2E job timeout to 180 minutes #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cron-main-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 90
timeout-minutes: 180
steps:
- name: "Checkout"
uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-release-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ubuntu-latest
timeout-minutes: 90
timeout-minutes: 180

steps:
- name: "Checkout"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ concurrency:
jobs:
release:
runs-on: ubuntu-latest
timeout-minutes: 90
timeout-minutes: 180
steps:
- name: "Checkout"
uses: actions/checkout@v7
Expand Down
10 changes: 8 additions & 2 deletions docs/e2e_tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,16 @@ one domain, and uses whichever collection makes the case observable.
## Running Tests

```bash
make e2e # run the E2E suite
make e2e args="tests/e2e/catalog" # run a subset of E2E tests
make e2e # run the E2E suite
make e2e path=tests/e2e/catalog # run a subset of E2E tests
make e2e args="-k test_create_variant" # pass extra pytest options
```

The target always passes a test path (`tests/e2e` unless `path` is set), so `args` only
carries options. Passing options alone used to drop the path and fall back to `testpaths`,
which made CI run the unit suite again after the E2E tests. E2E runs also disable coverage
(`--no-cov`) so they do not overwrite the unit `coverage.xml` that SonarCloud reads.

E2E tests need live API credentials and run against the real API, so they have their own
target: `make test` covers `tests/unit` only, and `make check-all` does not run them.

Expand Down
3 changes: 2 additions & 1 deletion docs/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ Run all test commands through Docker-based make targets:
```bash
make test
make test args="tests/unit/http"
make test args="tests/e2e"
make e2e
make e2e path=tests/e2e/catalog
make check
make check-all
```
Expand Down
2 changes: 1 addition & 1 deletion make/repo.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## Add repo-specific targets here. Do not modify the shared *.mk files.
e2e: ## Run e2e test
$(RUN) pytest -p no:randomly --junitxml=e2e-report.xml $(if $(args),$(args), tests/e2e)
$(RUN) pytest -p no:randomly --no-cov --junitxml=e2e-report.xml $(or $(path),tests/e2e) $(args)