feat: add parlay as tool during enrichments - #94
Draft
mcombuechen wants to merge 1 commit into
Draft
Conversation
mcombuechen
force-pushed
the
82-tool-entry
branch
2 times, most recently
from
December 12, 2024 10:27
8a56cd7 to
796528b
Compare
mcombuechen
force-pushed
the
82-tool-entry
branch
from
December 12, 2024 10:30
796528b to
702814f
Compare
| // Handle possibly existing, legacy "Tools" entry | ||
| if bom.Metadata.Tools.Tools != nil { | ||
| //nolint:staticcheck // Intentionally using a deprecated type in this case. | ||
| *bom.Metadata.Tools.Tools = append(*bom.Metadata.Tools.Tools, cdx.Tool{ |
Contributor
There was a problem hiding this comment.
Should we check if name (and version for the components) already exists? I assume we don't want to clutter the tools array with parlay multiple times if the users runs different enrichers sequentially
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds parlay as a tool used during SBOM creation when running
ecosystems enrichscorecard enrichsnyk enrichThis behaviour is opt-out through the
--omit-watermarkflag.Closes #82.