Skip to content

fix(update): select ldd2-35 build on glibc below 2.38 and verify before replace - #589

Open
Tyagiquamar wants to merge 1 commit into
smartcontractkit:mainfrom
Tyagiquamar:fix/582-linux-glibc-threshold
Open

fix(update): select ldd2-35 build on glibc below 2.38 and verify before replace#589
Tyagiquamar wants to merge 1 commit into
smartcontractkit:mainfrom
Tyagiquamar:fix/582-linux-glibc-threshold

Conversation

@Tyagiquamar

Copy link
Copy Markdown

Summary

  • Raise the glibc compatibility threshold from 2.36 to 2.38 so Debian 12 and similar hosts download cre_linux_*_ldd2-35.
  • Verify the downloaded binary runs before replacing the installed CLI; restore the previous binary from .bak if post-install verification fails.
  • Align install/install.sh threshold with cre update.

Test plan

  • go test ./cmd/update/...
  • go vet ./cmd/update/...

Fixes #582

…re replace

PR smartcontractkit#525 used a 2.36 threshold, but the default Linux asset requires glibc
2.38 (Debian 12 / Ubuntu 22.04 still break). Back up the current binary,
verify the downloaded build runs, and restore on failure.

Fixes smartcontractkit#582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cre update installs a glibc-2.38 binary on glibc-2.36 hosts and bricks the CLI (an _ldd2-35 asset exists but is never selected)

1 participant