Skip to content

Fix literal from addresses in ETHTx tasks - #23717

Open
ChrisWozniak wants to merge 1 commit into
smartcontractkit:developfrom
ChrisWozniak:fix-21768-ethtx-literal-from
Open

Fix literal from addresses in ETHTx tasks#23717
ChrisWozniak wants to merge 1 commit into
smartcontractkit:developfrom
ChrisWozniak:fix-21768-ethtx-literal-from

Conversation

@ChrisWozniak

Copy link
Copy Markdown

Fixes #21768

Requires

  • None.

Supports

  • None.

Summary

  • Accept a literal EVM address for an ethtx task's from parameter.
  • Preserve existing variable-expression and JSON-array from behavior.
  • Add a regression case for the reported bare-address input.

Testing

  • ./tools/test/.bin/test --ai-output -v -count=1 -run '^TestETHTxTask$' ./core/services/pipeline

Risk assessment

Low. The change is limited to ETHTxTask parameter resolution and is covered by the focused task suite.

Review focus

Please verify that literalAddressSlice recognizes only valid literal addresses and falls through to the existing JSON/variable resolvers for all other inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NODE] ethtx task with from (field) address always fails with "cannot convert int64"

2 participants