[CRE] Remove legacy workflow spec factories, v1 artifacts and workflow job paths - #23713
Open
bolekk wants to merge 1 commit into
Open
[CRE] Remove legacy workflow spec factories, v1 artifacts and workflow job paths#23713bolekk wants to merge 1 commit into
bolekk wants to merge 1 commit into
Conversation
Contributor
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
bolekk
force-pushed
the
keystone_wasm_cleanup_2
branch
from
September 10, 2026 21:03
718421a to
be671e8
Compare
bolekk
marked this pull request as ready for review
September 10, 2026 21:04
product-security-plaid-production
Bot
requested review from
kalverra,
patrickhuie19 and
prashantkumar1982
September 10, 2026 21:04
bolekk
marked this pull request as draft
September 10, 2026 21:15
…w job paths (L1) - delete YAMLSpecFactory, WasmFileSpecFactory, WorkflowSpecFactory registry and tests - strip WorkflowSpec.Validate/SDKSpec/RawSpec/GetConfig + legacy sdk import; WorkflowSpec is now a plain row model for workflow_specs_v2 - orm: drop workflow_specs insert, FindJobIDByWorkflow and delete cascade; CreateJob now rejects Workflow with ErrJobTypeRemoved - feeds: drop workflow auto-approval lookup and workflow job deletion/cancellation paths - delete prod-dead artifacts v1 package; rework job_orm_test and feeds tests - remove testdata/wasm legacy guest module, testdata/config.json and .gitignore entries - drop stale core/capabilities/compute/** path from CI wasm cache key - cmd/cre README: remove dead legacy data_feeds example section - system-tests: accept() no longer tolerates already-approved workflow specs
bolekk
force-pushed
the
keystone_wasm_cleanup_2
branch
from
September 10, 2026 22:22
be671e8 to
a02cc6e
Compare
|
jmank88
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy DAG WASM cleanup