Add bridge-cache fallback for UseConnectionManager bridge tasks - #23695
Open
denis-chernov-smartcontract wants to merge 1 commit into
Open
Add bridge-cache fallback for UseConnectionManager bridge tasks#23695denis-chernov-smartcontract wants to merge 1 commit into
denis-chernov-smartcontract wants to merge 1 commit into
Conversation
product-security-plaid-production
Bot
requested review from
DylanTinianov,
Krish-vemula and
patrickhuie19
September 9, 2026 23:00
Contributor
|
👋 denis-chernov-smartcontract, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
denis-chernov-smartcontract
force-pushed
the
DS/useConenctionManager-fallback-to-use-observation-cache
branch
from
September 9, 2026 23:36
111eb7c to
5c33a93
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bridge tasks that use the connection-manager (
UseConnectionManager) previously returned an error immediately when the in-memory observation was unavailable or expired. This PR makes them fall back to the persisted bridge response cache, matching the behavior of the HTTP bridge path.Changes
core/services/pipeline/task.bridge.goresolveFailureOrCachehelper for connection-manager failures instead of duplicating cache fallback logic.cacheTTL > 0, so subsequent failures can fall back to them.LocalCacheHitandResponseDatareflect the final response.core/services/pipeline/task.bridge_test.goTestBridgeTask_UsesBridgeConnManagerCacheFallbackto verify that a missing observation is resolved from the seeded bridge cache and that telemetry reports the cache hit.Testing
go test ./core/services/pipeline -run TestBridgeTask_passes.go test ./core/services/pipelinepasses.