Skip to content

fix: Execution Errors in More than F nodes not alerting on user errors #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agparadiso wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix: Execution Errors in More than F nodes not alerting on user errors #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion http_action/common/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,11 @@ func (m *Metrics) IncrementExecutionError(ctx context.Context, proxyMode ProxyMo
}

func (m *Metrics) IncrementExecutionTimeout(ctx context.Context, proxyMode ProxyMode, lggr logger.Logger) {
// NOTE: timeouts are user errors (the user's configured request Timeout expired, or the
// external endpoint was too slow for it). They are tracked separately via
// http_action_execution_timeout_count and must NOT be counted as execution errors,
// otherwise the "Execution Errors in More than F nodes" alert fires on user errors.
m.executionTimeout.Add(ctx, 1, metric.WithAttributes(attribute.String(AttrProxyMode, proxyMode.String())))
m.executionError.Add(ctx, 1, metric.WithAttributes(attribute.String(AttrProxyMode, proxyMode.String())))
}

func (m *Metrics) IncrementExternalEndpointError(ctx context.Context, proxyMode ProxyMode, lggr logger.Logger) {
Expand Down
Loading