Repository navigation
Himanshupal/sk 3168 flowvault java parity fix - #440
Open
skyflow-himanshupal wants to merge 6 commits into
Open
skyflow-himanshupal wants to merge 6 commits into
skyflow-himanshupal wants to merge 6 commits into
Conversation
…-Java-parity-fix SK-3168,SK-3204-Add-query-getTokens-uploadFiles-and-deleteFiles-to-flowvault
skyflow-himanshupal
requested review from
saileshwar-skyflow and
skyflow-bharti
October 16, 2026 10:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## flowvault-release/26.10.3 #440 +/- ##
===============================================================
+ Coverage 90.99% 91.39% +0.40%
- Complexity 0 605 +605
===============================================================
Files 174 197 +23
Lines 7350 8126 +776
Branches 1013 1131 +118
===============================================================
+ Hits 6688 7427 +739
- Misses 437 449 +12
- Partials 225 250 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the four unary operations from the Java flowvault design doc —
vault().query(),vault().getTokens(),vault().uploadFiles()andvault().deleteFiles()— and migrates the flowvault SDK to the regenerated Fern client.Why
records,tokens,queryandfilesresources replaceflowserviceand theV1*types), so the existing operations were migrated to it.Goal
SELECTand returnsfields,metadata.columnsand the call'srequestId.PUT. Each column reportsUPLOADED,FAILEDorSKIPPED. AcceptsfilePath,base64orfileObject.skyflowIdoruniqueValues, returning{column, status}per record.*Optionsfor custom headers, and come withBase*classes incommon, validation, README sections and samples.sdk-integration-tests).Testing
UploadFilesFormatsTestsruns real uploads against a local HTTP server: 30 file formats × 3 sources, checking bytes,Content-Type, file name and method. It also covers a large file, an empty file, overrides, a storage-side rejection and an upload longer than the vault-call timeout.common184,skyvault575,flowvault941.Tech debt