SK-3222 fix internal release

[skyflow-bharti]

Goal

Internal releases to Artifactory have failed with HTTP Status: 401 on every run since 8 October, for both skyvault and flowvault. This PR makes them publish again.

Why it became an issue

Nothing in the repo changed. The GitHub ubuntu-24.04 runner image published on 4 October upgraded Maven from 3.9.16 to 3.10.0, and two things Maven 3.9 only warned about are now fatal:

1. Maven 3.10 scopes server credentials to the host the server id belongs to. The id central is bound to Maven Central. Our jfrog profile reused central for the Artifactory repository, so Maven logged Not using credentials of server 'central' for repository https://prekarilabs.jfrog.io/... and sent the upload with no credentials. Artifactory returned 401. The secrets themselves were valid.
2. Maven 3.10 rejects duplicate plugin declarations. Both poms declared maven-shade-plugin twice, which now fails the build before it starts.

What we fixed

• flowvault/pom.xml, skyvault/pom.xml: the jfrog profile's deploy repository id is now skyflow-jfrog instead of central.
• .github/workflows/internal-release.yml: server-id: skyflow-jfrog, so the credentials are written under the matching id.
• flowvault/pom.xml, skyvault/pom.xml: the two maven-shade-plugin entries are merged into one plugin with two executions. Same configuration, same jars.

Not affected

The public release path. release.yml and the maven-central profile keep central, and the Sonatype upload goes through central-publishing-maven-plugin, which is outside Maven's credential scoping. Published artifacts are unchanged.

Verified with Maven 3.10.0 locally

Both modules build with no duplicate-plugin error, the internal deploy now attaches the credentials, and the public profile behaves as before.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (eecd06a) to head (a9b83ce).

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #439      +/-   ##
============================================
+ Coverage     90.99%   91.00%   +0.01%     
- Complexity        0      545     +545     
============================================
  Files           174      174              
  Lines          7350     7350              
  Branches       1013     1013              
============================================
+ Hits           6688     6689       +1     
  Misses          437      437              
+ Partials        225      224       -1     

Flag	Coverage Δ
common	89.45% <ø> (+0.30%)	⬆️
flowvault	87.93% <ø> (ø)
skyvault	94.85% <ø> (-0.11%)	⬇️
unittests-flowvault	89.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Module: common	89.45% <ø> (+0.30%)	⬆️
Module: skyvault	94.85% <ø> (-0.11%)	⬇️
Module: flowvault	87.93% <ø> (ø)
Service Account	87.36% <ø> (ø)
Vault Data	90.81% <ø> (ø)
Vault Tokens	99.03% <ø> (ø)
Vault Connection	100.00% <ø> (ø)
Vault Controller	82.75% <ø> (ø)
Detect	100.00% <ø> (ø)
Audit	100.00% <ø> (ø)
BIN Lookup	100.00% <ø> (ø)
Config	96.26% <ø> (ø)
Utils	90.41% <ø> (+0.04%)	⬆️
Errors	100.00% <ø> (ø)
Enums	100.00% <ø> (ø)
Logs	95.60% <ø> (ø)
see 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecd06a...a9b83ce. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟢 Approval recommended

The configuration changes are consistent, preserve existing Shade executions, and have no identified blocking issues.

0 open findings

What changed in this PR

Fixes internal release configuration by aligning JFrog repository and credential IDs and consolidating Maven Shade plugin declarations.

Changes:

• Uses skyflow-jfrog consistently in both modules and the internal release workflow.
• Consolidates Shade executions under one plugin declaration per module, preserving comparison-only jars.

File	Description
skyvault/​pom.xml	Consolidates Shade configuration and updates the JFrog repository ID.
flowvault/​pom.xml	Consolidates Shade configuration and updates the JFrog repository ID.
.github/​workflows/​internal-release.yml	Matches the credential server ID to skyflow-jfrog.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.