Repository navigation
Fix crash screen bugs and restore the API validation - #15
Merged
Merged
Conversation
- Light colors painted white text on a white background, so every message, the device info, the stack trace, and the copy icon were invisible - SnitcherInstaller never flipped its installed flag, so Snitcher.isInstalled always returned false - The copy action copied the exception message instead of the stack trace - A null launcher threw inside the datastore collector and crashed the app - The trace screen background stopped at the content height - Captured stack trace elements dropped the file name - Replace the removed accompanist system ui controller, which is a no-op on Android 15 and above, with WindowInsetsControllerCompat and enableEdgeToEdge
skydoves
changed the title
AGP 9 built-in Kotlin does not expose the Android compilations to either the binary compatibility validator or the ABI validation of the Kotlin Gradle plugin, so apiDump and checkKotlinAbi write nothing and the check passes against whatever dump is already committed. Opt out of built-in Kotlin and the new DSL, both of which AGP 9 offers for exactly this case, apply the Kotlin Android plugin again, and put the validator back in charge of the api dump. The demo and the benchmark modules are excluded, since only the library is published.
skydoves
force-pushed
the
fix/crash-screen-bugs
branch
from
September 16, 2026 12:33
e5ca00a to
ae06569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The light palette used white text on a white background, so the exception message, device info, stack trace, and the restore screen texts were all invisible in light mode.
Also fixes Snitcher.isInstalled always returning false, the copy button copying the message instead of the stack trace, a null launcher crashing the datastore collector, the background not filling the screen, dropped file names in captured stack traces, and the removed accompanist system ui controller that is a no-op on Android 15 and above.
The last commit restores the binary compatibility validation, which AGP 9 built-in Kotlin silently turned into a no-op, so the api dump is checked again.