Repository navigation
Conversation
| "CHROMA_DB_PATH", | ||
| "/PeTTa/chroma_db" if os.path.isdir("/PeTTa/chroma_db") else | ||
| os.path.join(_PROJECT_ROOT, "..", "..","chroma_db") | ||
| ) |
There was a problem hiding this comment.
@amxson Is dropping CHROMA_DB_PATH here intentional? Import/export still use it, while lib_chromadb uses ./chroma_db. Could that make them point to different databases when a custom path is set?
There was a problem hiding this comment.
Good catch. I restored CHROMA_DB_PATH handling while keeping RAG and runtime on the same shared collection. I also resolve the paths before comparing them so equivalent paths don’t open another client.
| if background: | ||
| try: | ||
| _knowledge_worker = threading.Thread( | ||
| target=_index_knowledge, |
There was a problem hiding this comment.
The thread drops the result returned by _index_knowledge(), so we never see the final summary or “no files found” message. Could we log it when the worker finishes?
There was a problem hiding this comment.
Yep, fixed. The background worker now logs the result from _index_knowledge(), including the normal summary and the no-files case.
There was a problem hiding this comment.
@amxson Both fixes look good, thanks! Could you update the branch with the latest main so we can run CI before merging?
|
Updated with latest main. Local tests pass, including the mandatory suite. |
b2ff437 to
085d423
Compare
Description
Knowledge indexing currently blocks startup until changed files are embedded. This adds opt-in
knowledgeIndexingBackgroundso plugins and channels can start while knowledge becomes available progressively.Indexing uses the runtime Chroma collection. The setting defaults to false, preserving the existing synchronous behavior.
Closes #384.
How Has This Been Tested?
Checklist