Skip to content

Let the app own Referrer-Policy (SR-2589) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsokol merged 2 commits into from
Nov 13, 2026
Merged

Let the app own Referrer-Policy (SR-2589) #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6955ac
Let the app own Referrer-Policy; stop the vhost sending a conflicting…
jsokol Nov 13, 2026
6683966
Stop forcing HSTS and X-XSS-Protection from the vhost (SR-2589)
jsokol Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions simplerisk-minimal/common/etc/apache2/sites-enabled/default-ssl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ SSLStrictSNIVHostCheck Off
# combined format above does not carry.
CustomLog /var/log/apache2/ssl_request_log "%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}x \"%r\" %b"

Header always set Strict-Transport-Security "max-age=63072000; includeSubdomains; preload"
Header always set X-Xss-Protection "1; mode=block"
Header always set Referrer-Policy "no-referrer-when-downgrade"
# SR-2589: the app (add_security_headers() in includes/functions.php) owns Referrer-Policy and sends
# `origin`. A header set here with `always` is emitted in addition to the app's, giving two
# conflicting values. setifempty only fills it in for responses the app did not set (static files).
Header setifempty Referrer-Policy "origin"
Header always unset X-Powered-By
Header unset X-Powered-By
Header always unset X-Generator
Expand Down
7 changes: 4 additions & 3 deletions simplerisk/common/etc/apache2/sites-enabled/default-ssl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ SSLStrictSNIVHostCheck Off
SetEnvIf User-Agent ".*MSIE.*" nokeepalive ssl-unclean-shutdown
CustomLog /var/log/apache2/ssl_request_log "%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}x \"%r\" %b"

Header always set Strict-Transport-Security "max-age=63072000; includeSubdomains; preload"
Header always set X-Xss-Protection "1; mode=block"
Header always set Referrer-Policy "no-referrer-when-downgrade"
# SR-2589: the app (add_security_headers() in includes/functions.php) owns Referrer-Policy and sends
# `origin`. A header set here with `always` is emitted in addition to the app's, giving two
# conflicting values. setifempty only fills it in for responses the app did not set (static files).
Header setifempty Referrer-Policy "origin"
Header always unset X-Powered-By
Header unset X-Powered-By
Header always unset X-Generator
Expand Down
Loading