Repository navigation
Keep compliance_markup's Compliance Engine hierarchy in spec_helper.rb - #125
Merged
Merged
Conversation
pupmod-simp-compliance_markup's specs exercise the compliance_markup::enforcement Hiera backend through the default test hierarchy in spec/spec_helper.rb, and fail without it. The template dropped that entry, so every sync of spec_helper.rb broke the module's specs, and the module had drifted from the template to keep them working. Add the entry to the template for simp-compliance_markup only, the same way simp-simpkv gets its DataHelper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
silug
force-pushed
the
spec-helper-compliance-markup
branch
from
October 26, 2026 16:06
5424312 to
3c70d98
Compare
silug
enabled auto-merge (rebase)
October 26, 2026 16:06
michael-riddle
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pupmod-simp-compliance_markup's specs exercise the
compliance_markup::enforcementHiera backend through the default test hierarchy inspec/spec_helper.rb:The template doesn't include that entry. Rendering it for compliance_markup drops the entry, and specs such as
spec/functions/compliance_markup/10_enforce_spec.rbfail (lookup() did not find a value for the name 'useradd::shells'). To keep its specs working, the module had drifted from the template, and it was still missing later template changes such as the atomichiera.yamlwrite.This PR adds the entry to the template for
simp-compliance_markuponly, the same waysimp-simpkvgets itsDataHelper.Testing:
puppet epp validatepasses.simp-compliance_markup, the template matches byte for byte thespec/spec_helper.rbin Sync baseline files with puppetsync and add OpenVox 9 support pupmod-simp-compliance_markup#225, where all specs pass.simp-simpkvandsimp-auditd, the output is identical tomain's.🤖 Generated with Claude Code