Repository navigation
Conversation
openvox-strings releases change the generated REFERENCE.md (7.2.0 dropped the trailing blank line), and the pupmod PR tests fail any PR whose REFERENCE.md doesn't match. A session that didn't list the generate_reference_md stage then opened PRs that failed over drift they didn't cause. The sync plan now adds generate_reference_md to any session whose stages include git_commit_changes. Run implicitly, the task gets the new only_changed parameter and skips modules without a REFERENCE.md and modules that no earlier stage changed, so it never creates a REFERENCE.md or widens a session to repos it had no other reason to touch. Listing the stage keeps the old behavior: regenerate in every pupmod in the session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openvox-strings releases change the generated REFERENCE.md: 7.2.0 drops the trailing blank line that 7.1.0 wrote. The pupmod PR tests run
rake validate:strings, so every PR from a session that didn't listgenerate_reference_mdfailed theREFERENCE.md freshnesscheck, over drift the session didn't cause. The20261002-openvox9-gaPRs are an example.Change
plans/init.pp: if a session'sstagesincludegit_commit_changesbut notgenerate_reference_md, the plan adds the stage. No config changes are needed; the next run of any session picks it up.tasks/generate_reference_md: newonly_changedparameter, which the plan sets when it added the stage itself. It skips a module that has no REFERENCE.md (so one is never created) and a module with no uncommitted changes from earlier stages (so the stage never pulls a repo into a session for drift alone). The result reportsskippedwith the reason.One limitation: a re-run onto an existing feature branch whose changes are already committed has a clean tree, so the implicit stage skips it. Listing the stage covers that case.
Testing
spec/plans/generate_reference_md_stage_spec.rb): implicit withonly_changed: truefor a committing session,only_changed: falsewhen the stage is listed, and not run for a session that doesn't commit.only_changed: regenerates in a changed repo, skips a clean repo, and doesn't create a missing REFERENCE.md.rspec: 252 examples, 0 failures. Plan specs: 34 examples, 0 failures.bolt plan show puppetsyncloads.🤖 Generated with Claude Code