Skip to content

fix: replace bare except clause with specific exception types in claude_to_markdown.py - #345

Closed
KooshaPari wants to merge 1 commit into
simonw:mainfrom
KooshaPari:fix-claude-md-bare-except
Closed

fix: replace bare except clause with specific exception types in claude_to_markdown.py#345
KooshaPari wants to merge 1 commit into
simonw:mainfrom
KooshaPari:fix-claude-md-bare-except

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Sep 13, 2026

Copy link
Copy Markdown

Changes

  • Replaced bare except: with except (ValueError, TypeError): in format_timestamp()
  • Bare except clauses catch SystemExit and KeyboardInterrupt, silently swallowing them
  • Only catches the exceptions that datetime.fromisoformat() and .strftime() actually raise

Copilot AI lite review requested due to automatic review settings September 13, 2026 06:09
Copilot AI reviewed Sep 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@KooshaPari KooshaPari closed this by deleting the head repository Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KooshaPari