Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL queries currently have no session-variable link to the OpenTelemetry database span that caused them. This adds an experimental, explicitly enabled Connector/Python hook that writes the database child span's W3C context to
@traceparentbefore execution and attempts to clear it afterward, including after a query error.The hook supports built-in buffered tuple, raw, and dictionary cursors in pure Python and C extension modes. It checks for pending results and accepts a conservative set of single-result SQL statements. Streaming and prepared cursors, scripts, stored-procedure calls, batches, custom cursor or connection subclasses, and SQLCommenter queries run without correlation commands. Internal SET commands create no extra spans. Suppressed calls and no-op tracers do not inject the application parent context.
Validation: 157 tests passed, including 48 real MySQL 8.4.11 cases with Connector/Python 26.7.0 and DBAPI instrumentation 0.66b1. Checks cover exact database child-span IDs, buffered rows after cleanup, query errors, unsampled context, suppression, transaction boundaries, and unsupported execution paths. Ruff checks and formatting passed.
docs/mysql.mdincludes usage and test instructions.This remains a draft: the hook uses private DBAPI and driver interfaces, adds two SET commands per eligible execution, and changes session diagnostics such as
ROW_COUNT()and warning state. Internal SET failures are logged without replacing the query result or error, but can leave stale context. Startup configuration, connection-pool validation, additional execution modes and drivers, overhead measurement, and Collector/DBMon validation remain pending.