Skip to content

fix(unicodedata): mirrored returns int where CPython expects (#712) #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
espetro merged 4 commits into from
Oct 27, 2026
Merged

fix(unicodedata): mirrored returns int where CPython expects (#712) #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
305f196
fix(unicodedata): mirrored returns int where CPython expects (#712)
espetro Oct 27, 2026
9ccda85
fix(unicodedata): restore chmod mode param and textwrap indent prefix…
espetro Oct 27, 2026
a55fdea
test(call-table): drop the recorded #712 divergence from the mirrored…
espetro Oct 27, 2026
c831ec7
fix(stdmore): keep master's table and change only unicodedata.mirrore…
espetro Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyscriptc/stdmore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,7 @@ def _host_attr(owner: Any, name: str) -> Any:
"is_normalized": _sig([_S, _S], _B, "ps_unicode_is_normalized"),
"bidirectional": _sig([_S], _S, "ps_unicode_bidirectional"),
"east_asian_width": _sig([_S], _S, "ps_unicode_east_asian_width"),
"mirrored": _sig([_S], _B, "ps_unicode_mirrored"),
"mirrored": _sig([_S], _I, "ps_unicode_mirrored"),
"decimal": _sig([_S], _I, "ps_unicode_decimal"),
"digit": _sig([_S], _I, "ps_unicode_digit"),
"numeric": _sig([_S], _F, "ps_unicode_numeric"),
Expand Down
3 changes: 1 addition & 2 deletions tests/test_stdlib_call_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
# a real difference from CPython 3.14 tracked as an issue; the entry is what
# makes the batch an xfail instead of a failure, and it must be removed when
# the row is fixed (the batch then passes on its own).
MIRRORED_DIVERGENCE = "issue #712 (unicodedata.mirrored return kind)"
PLATFORM_DIVERGENCE = "issue #713 (platform.platform output)"
REALPATH_DIVERGENCE = "issue #714 (os.path.realpath on a missing target)"

Expand Down Expand Up @@ -372,7 +371,7 @@ def _p(module: str, member: str, group: str, *lines: str, divergence: str | None
_p("unicodedata", "is_normalized", "text", "print(unicodedata.is_normalized('NFC', 'caf\\u00e9'))"),
_p("unicodedata", "bidirectional", "text", "print(unicodedata.bidirectional('a'))"),
_p("unicodedata", "east_asian_width", "text", "print(unicodedata.east_asian_width('a'))"),
_p("unicodedata", "mirrored", "text", "print(unicodedata.mirrored('('))", divergence=MIRRORED_DIVERGENCE),
_p("unicodedata", "mirrored", "text", "print(unicodedata.mirrored('('))"),
_p("unicodedata", "decimal", "text", "print(unicodedata.decimal('7'))"),
_p("unicodedata", "digit", "text", "print(unicodedata.digit('7'))"),
_p("unicodedata", "numeric", "text", "print(unicodedata.numeric('7'))"),
Expand Down
Loading