Skip to content

sift(chore): update public protos - #869

Merged
alexluck-sift merged 3 commits into
mainfrom
al/sift/chore/update-public-protos
Nov 5, 2026
Merged

alexluck-sift merged 3 commits into
mainfrom
al/sift/chore/update-public-protos

Conversation

@alexluck-sift

@alexluck-sift alexluck-sift commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Commit SHA: 09104f647e

Syncs the public protos and the generated Go, Python, and Rust code. Four proto files change. Nothing is removed or renamed.

Notable changes:

  • Artifacts: ArtifactVersion.file_sha256, the lowercase hex SHA-256 that the client sent with the upload. GetArtifact, ListArtifacts, and ListArtifactVersions return it.
  • Artifacts: ListArtifactLinks, BatchArchiveArtifacts, and BatchUnarchiveArtifacts.
  • Artifacts: ARTIFACT_STORAGE_CLASS_STRUCTURED and payload are deprecated, because the service no longer accepts structured artifacts.
  • Data imports: leave_run_open on CreateDataImportFromUrlRequest and CreateDataImportFromUploadRequest
  • Common: RESOURCE_TYPE_ACTOR_ACTION
  • Remote files: comment-only changes

Code outside the generated output:

  • sift_test_util: the ArtifactService mock implements the three new artifact RPCs
  • sift_mcp: CreateArtifactRequest fills its remaining fields from Default, so it no longer names the deprecated payload field

Codegen ran with scripts/gen.sh against the existing protos/buf.lock. The buf mod update step was skipped, because a newer googleapis dependency changes the descriptor of every generated file. The regenerated Rust files keep the trailing-whitespace and end-of-file rules from pre-commit.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-869/

Deployed from 09ce3d2. The link may take up to a minute to become live as GitHub Pages propagates.

@alexluck-sift
alexluck-sift added this pull request to stack #871 November 4, 2026 23:39
@alexluck-sift
alexluck-sift marked this pull request as ready for review November 5, 2026 00:04

@wei-sift wei-sift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexluck-sift
alexluck-sift merged commit 70c0b38 into main Nov 5, 2026
27 checks passed
@alexluck-sift
alexluck-sift deleted the al/sift/chore/update-public-protos branch November 5, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants