Repository navigation
Conversation
omar-sift
force-pushed
the
dev/ENG-16360-sift-cli-export-no-jobid
branch
from
November 4, 2026 22:38
4b1617e to
ec2e7a3
Compare
omar-sift
marked this pull request as ready for review
November 4, 2026 22:55
brandonshippy-sift
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an organization has the
async-exportsfeature flag off,ExportDatadoes not return ajob_id.sift-cli exportassumed a job ID was always present:export --no-waitprintedStarted export jobwith a blank ID, linked to/manage/jobs?jobId=, and exited 0.exportwithout--no-waittried to fetch the job and failed withfailed to retrieve job by ID.exportnow checks for an emptyjob_idbefore it polls or prints a job link. It prints an error, links to the Sift jobs page, and exits 1:Without a configured
app_uri, the tip points tosift-cli config update --app-uri, as the other export messages do.build_jobs_page_urlfor the jobs page link.build_jobs_urlnow builds on it.sift-cli. Scripts that relied on exit status 0 fromexport --no-waitnow fail.Verification
cargo test -p sift_clipasses. Newexplore_urltests cover the jobs page link,jobIdencoding, and a missing, empty, or slash-onlyapp_uri.cargo fmt --checkpasses.sift-cli export asset ... --no-waitandsift-cli export asset ...against a local server withasync-exports=off. Both print the error above and exit 1.