Repository navigation
python(fix): include server error message in sift_client HTTP errors - #864
Merged
wei-sift merged 3 commits intoNov 4, 2026
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-864/ Deployed from |
wei-sift
marked this pull request as ready for review
November 3, 2026 01:25
brandonshippy-sift
previously approved these changes
Nov 3, 2026
alexluck-sift
approved these changes
Nov 4, 2026
wei-sift
deleted the
eng-16487-include-server-error-message-in-sift_client-upload-failures
branch
November 4, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed uploads only showed
400 Client Error: Bad Request for url: ...becauseraise_for_status()drops the response body, so the server's reason was hidden. This adds a small helper that includes the server's response in the error and uses it for all file uploads and downloads insift_clientTested by importing a CSV with a month-first timestamp. The error now ends with
Server response: ...instead of a generic message