Repository navigation
Remove framework LMV v0.x.x - #145
Merged
Merged
Conversation
carlos-villavicencio-adsk
requested review from
a team,
chenm1adsk and
stevelittlefish
and
a balanced review from Copilot
September 30, 2026 17:41
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The obsolete entry is removed cleanly, and no remaining repository references require LMV v0.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the obsolete LMV v0 framework configuration after supported Alias and VRED engines migrated to v1.
Changes:
- Deletes the
tk-framework-lmv_v0.x.xdefinition. - Retains LMV v1.1.0 as the supported version.
| File | Description |
|---|---|
env/includes/common/frameworks.yml |
Removes the unused LMV v0.2.2 framework entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
barbara-darkshot
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3 years ago, tk-alias and tk-vred engine bumped tk-framework-lmv to v1.x.x:
The older version raised some security findings, so we're removing this as no currently supported engine is using it.
Jira
This should directly address: SG-45349 SG-45350 SG-45351 SG-45352 SG-45354 SG-45355 SG-45356 SG-45357 SG-45358 SG-45359 SG-45361 SG-45362 SG-45363 SG-45364 SG-45365 SG-45366 SG-45367 SG-45368 SG-45370 SG-45371 SG-45373 SG-45376
Likely, but not proven:
SG-45348 SG-45353 SG-45360 SG-45369
SG-45348, SG-45353, SG-45360 (OpenJPEG): Qt's PDF engine also contains OpenJPEG, so these may not all go away.
SG-45369 (FreeType 2.3.11): the only copies without a readable version are in LMV v0 DLLs, but I couldn't confirm the version from the binary.
A rescan after the change will settle these four.