Generalize breadcrumbs to nested paths; add brandColor config - #63
Open
RobbieTheWagner wants to merge 1 commit into
Open
Generalize breadcrumbs to nested paths; add brandColor config#63RobbieTheWagner wants to merge 1 commit into
RobbieTheWagner wants to merge 1 commit into
Conversation
Breadcrumbs now build one crumb per path segment, so a custom nested page like /collections/[slug] gets a linked intermediate crumb (named by humanizing the segment) instead of jumping straight from Home to the page title. The trail also feeds the BreadcrumbList schema, and the last crumb gets aria-current="page". Injected core routes are all single-segment, so their rendering is unchanged. New optional brandColor config field (validated as a hex color) sets the Safari pinned-tab icon color and Windows tile color, which were hardcoded to the favicon-generator template values. Both restore customizations whiskey.fm carried in its fork before converting to the npm package. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two Layout-level customization gaps that surfaced when converting whiskey.fm (www-starpod) from a fork into an npm consumer — the fork carried both, and the package had no hook for either.
Nested breadcrumbs
Breadcrumbs.astronow builds one crumb per path segment: a custom nested page like/collections/[slug]rendersHome > Collections > <title>with the intermediate crumb linked and named by humanizing its segment, instead of jumping straight from Home to the page title. The full trail feeds theBreadcrumbListschema, and the last crumb getsaria-current="page". All injected core routes are single-segment, so their rendering is unchanged (verified against the built/aboutand episode pages).brandColorconfigNew optional config field, validated as a hex color, that sets the Safari pinned-tab
mask-iconcolor andmsapplication-TileColor— both were hardcoded to the favicon-generator template values (#5bbad5/#da532c), which remain the defaults. Documented in the package README, with a config validation test.Verification
brandColorvalidation case);astro checkand a full reference-site build pass./collections/test-crumbpage: linkedCollectionscrumb,aria-current, 3-item schema, andbrandColor: '#531b3c'flowing into both head tags.🤖 Generated with Claude Code