ldap: bound the bytes materialized while reassembling a search response - #5101
Open
KernelClint wants to merge 1 commit into
Open
ldap: bound the bytes materialized while reassembling a search response#5101KernelClint wants to merge 1 commit into
KernelClint wants to merge 1 commit into
Conversation
Segmented LDAP search responses are re-parsed from the start of the buffer on each arriving segment, so a valid multi-message response makes session-aware capture stall well past the point the data is complete. Bound the total bytes materialized per reassembly attempt. A segmented search response still returns LDAP_SearchResponseResultDone. A small valid multi-read response took 124,933.9 ns/call unmodified and 121,541.6 ns/call with this change. AI-Assisted: yes (GPT-5.6-Cyber)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A segmented LDAP search response is re-parsed from the start of the buffer as each segment
arrives, so an ordinary valid multi-message response makes session-aware capture stall well past
the point the data is complete. No malformed input is needed.
This bounds the total bytes materialized per reassembly attempt. A segmented search response still
returns
LDAP_SearchResponseResultDone.A small valid multi-read response took 124,933.9 ns/call unmodified and 121,541.6 ns/call with the
change.
Test added in
test/scapy/layers/ldap.uts. The focused LDAP suite failed 1 of 18 without the fixand passes 18 of 18 with it.