contrib/hicp: terminate Configure fields on the correct delimiter - #5100
Merged
gpotter2 merged 1 commit intoAug 25, 2026
Merged
Conversation
The Configure field ended on '!' rather than the ';' the format requires, so each field re-scanned the remainder of the packet and parsing cost grew with the square of the delimiter count. Using the required ';' removes the repeated suffix scans. AI-Assisted: yes (GPT-5.6-Cyber)
polybassa
approved these changes
Aug 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
+ Coverage 79.42% 80.58% +1.16%
==========================================
Files 372 390 +18
Lines 96507 96858 +351
==========================================
+ Hits 76652 78057 +1405
+ Misses 19855 18801 -1054
🚀 New features to boost your workflow:
|
gpotter2
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Configure field terminated on
!rather than the;the format requires, so each fieldre-scanned the rest of the packet and parsing cost grew with the square of the delimiter count.
Using the required
;removes the repeated suffix scans.Test added in
test/contrib/hicp.uts.