Conversation
github-actions
Bot
changed the title
Comment on lines
-164
to
+165
| twotheta_bins = _focussing_two_theta_bins(data.coords['two_theta'], two_theta_bins) | ||
| coords = data.coords if 'two_theta' in data.coords else data.bins.coords | ||
| twotheta_bins = _focussing_two_theta_bins(coords['two_theta'], two_theta_bins) |
Member
There was a problem hiding this comment.
Looks like an unrelated change?
Contributor
Author
There was a problem hiding this comment.
That's true!
I forgot that the change here is also supposed to address #743, allowing the modulation workflow to compute the same quantities as the other diffraction workflows, and that requires this change.
I'll update the PR description.
Contributor
Author
There was a problem hiding this comment.
The update is that I added "Fixes #743".
The change that you commented on is needed because in the (strictly speaking only the automatic peak finding) Beer modulation workflow the data is not binned by pixel at this stage in the workflow, so theta is an event coordinate.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the workflow names in BEER to make them more consistent, clear and fewer.
Fixed #743
It keeps the old workflow names but warns that they are deprecated.