Repository navigation
Replace monolithic Windows validation with a compiled contract runner - #956
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…merge Do not execute the legacy monolithic runner. Preserve source-only baseline dependencies for compiled contract migration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Preserve monotonic exit/drain deadlines, independent stream faults, primary errors and UNKNOWN retention. Add strict typed multiproject protocol and controlled native fixtures. Keep twelve legacy and production-linkage obligations explicitly incomplete. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Keep incomplete coverage nonzero; preserve owned supervision, suite provenance, and root console marker isolation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Run real supervisor teardown through the same coordinator as controlled fake authority cases. Preserve original primary objects, independently observe root/job/stream proofs, share one cleanup deadline, and continue later close actions after failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…racle Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Run exact receipt7/capture14/tree4/provider4/pre-UIA10/retention6 families through the compiled owned-child transport. Keep mixed and newly reconciled startup/tree assertions mandatory incomplete, with immutable 126-template/192-assertion source correspondence. Expose host terminal retention hold so process exit cannot close unproved jobs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Target production bindings at .NET 8 and fixture bindings at netstandard2.1; keep host .NET 10. Prevent process exit while retained UNKNOWN authority remains. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…nkage Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Observe the exact UNKNOWN sentinel incrementally in both shared production readers. Retain the original lease immediately, cancel controller waits only, and refuse termination or close after the latch. Add fake-only retention-decision tests and exact fragmented marker controls. Verify startup diagnostics and mixed source boundaries through protected linked-production adapters. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…ondence Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…rity Force explicit inherited stdout/stderr with a closed redirected stdin, without pumps or changing root-exit versus stream-EOF order. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Separate raw EOF proof from text decode failure and observe live retention markers independently of codec errors. Add safe controlled BOM/malformed/supplementary-byte regressions and execute the original eight gate capture modes plus native held-tree and real shared-linkage obligations. All165 selected ownership checks pass; the full mixed family remains mandatory incomplete. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Keep the production native delegate and existing fallback/refusal order; remove reliance on arbitrary preloaded type presence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
… source provenance Preserve root registry admission, source/ref fingerprints and loaded MVID checks, normal compiled fixtures, owned mock regression suites, and positive provider/source contract counts. Incomplete canonical coverage remains nonzero. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…ived proof Allow repeated exact suite selectors for bounded diagnostics while keeping all unselected mandatory units incomplete. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Port production-backed diagnostic, CI partition, aggregate, section, and Zig resolver cases with typed compiled CI topology guards and exact execution inventories. Preserve genuine pre-cutover CI source failures rather than accepting the legacy runner. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Exercise seven original producer AST predicates and nine negative controls through the protected host transport. Record existing UI and host ownership without counting those cases twice. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…nert transports Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Add actual PowerShell startup-event, stream identity, complete receipt, protocol, and real production-stub pipe families. Bind the independent UI policy and native fixture deliverables with exact expanded counts. Map all126 original templates onto133 unique dependencies and465 original expanded cases; keep two new focus failures separate. The frozen host composite schema must admit actual current results before root success. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Preserve the dedicated fail-closed Windows 2022 PR job and single non-PR hardening fallback. Install the exact SDK, build from the global.json directory, invoke the normal compiled host, and require fresh complete positive coverage with exactly one full PASS and execution marker. Keep compatibility entry compiled-only and preserve evidence artifacts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Let the apphost inherit the selected private SDK runtime without changing normal arguments or persistent settings. Restore exact process environment state after success or failure and exercise the production helper in sixteen targeted controls wired into topology validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reuse loaded or available Pester 5 and save pinned 5.7.1 only when missing, scoped to workspace modules and the current job environment. Guard prerequisite ordering and gating, and reject a missing loader without changing canonical execution or deadlines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…failures Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…ndary Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Preserve exact native dry-run exit status and no-effect source controls, required SDK regression counts, and non-double-counted composite coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
The integration host measured a successful unfiltered run at 973.70 seconds. Give both canonical execution steps 25 minutes and their containing jobs 40 minutes without changing commands, gates, or child-process deadlines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Opt into hidden files only under the explicit .ci-validation-runner artifact root in both canonical workflows. Add source coverage and missing/false negative controls so the hosted evidence-loss regression cannot silently recur. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
A real native stress reproducer observed400 empty job censuses before original process objects signalled. Preserve zero-time refusal for explicit finalization, but share one bounded scope-exit deadline across job quiescence and every held root before any launch closes. Add required44-case native helper coverage and70-case lifecycle regression including40 real module-owned roots; preserve no-close timeout and sibling negative controls. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Keep validation scoped to the main product baseline, preserve native window and smoke-exit behavior, finalize endpoint captures in the correct order, and observe daemon lifetime before job teardown. Add bounded native smoke controls and non-activating owned pointer fixtures without weakening recipient checks. Classify failing suites without printing private exception payloads. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the existing owned Show in Graph route after selection opens the loop workspace, reacquire the same card before Fit Canvas, and preserve the original pointer and selection guards. Clear the completed PowerShell stress job reference only after successful removal so cleanup cannot remove it twice. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ease Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…t resolution Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Build and validate once for a genuinely missing assembly environment entry, preserve supplied and empty semantics, and restore only the process publication after the task. Exercise native child inheritance and failure identity, and keep the strict fixture loader unchanged. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the monolithic PowerShell Windows validation contract with a normal compiled C# entry that cannot report success with missing coverage. Preserve the native validation preconditions and lifetime observations exposed by actual CI, without weakening required checks or executing the old monolith.
Changes
.ci-validation-runnerupload roots; classify console failures by sanitized suite ID and exception type without leaking raw payloads.GA_ROOTinput owner in the shared UIA helper. Five real hidden Win32 topology controls preserve strict PID, ancestry, recipient and exact-root admission; physical flat/nested clicks remain a separate interactive proof, not an inferred canonical result.App.zigfunctions:App.runsmoke-exit/reporting,runSmokeWorkspaceActionsprerequisites, andsmokeContractPassed's requested-but-unexecuted guard. No DaemonClient, Workspace, AppFont, GraphCanvas, shared Swift, or unrelated Cards feature changes.Test plan
RED: & .\Tools\windows\ValidationRunner\bin\Debug\net10.0-windows\ValidationRunner.exe --self-test -> actual behavioral run: 22 executed, 21 failed with "RED: coverage admission is not implemented"; original output retained
GREEN: & .\Tools\windows\ValidationRunner\bin\Release\net10.0-windows\ValidationRunner.exe --self-test -> 65 executed, 65 passed, 0 failed, 0 skipped on local commit 90479b3
REGRESSION: & .\Tools\windows\ValidationRunner\bin\Release\net10.0-windows\ValidationRunner.exe --repository-root $PWD --artifact-root (Join-Path $base 'pr956-90479b38-full') -> 605/605 units, 2094 direct checks, exit 0 on local commit 90479b3
Tools\windows\ValidationRunner:dotnet --versionselected 10.0.403;dotnet build -c Releasecompleted with 0 warnings and 0 errors.& .\Tools\windows\ValidationRunner\bin\Release\net10.0-windows\ValidationRunner.exe --repository-root $PWD --artifact-root $a, where$ais an owned evidence directory. Local commit90479b38passed 605/605 required units, 2,094 direct checks, exit 0,complete=true,fullInvocation=true, in 1,003.87 seconds. All 146 changed source-file hashes remained unchanged. The derived 465-case proof covers 126 original templates and is not counted again as direct execution.5a7a3bd4passed the compiled full 604/604, 2,087 direct checks and retained its scoped hidden artifact. Its unit 1 and native integration jobs then failed the same absent-assembly-environment prerequisite at GDI startup and scrubbed startup. Earlier local commands had a preset and did not exercise that CI path.GRAPHCODE_VALIDATION_ASSEMBLYexplicitly absent, passed 17/63 sections, and producedGDIPLUS_STARTUP_LIVE: PASS; executed=1; observations=2; original absence was restored afterward. Updated three-shard manifests independently passed 63 complete/disjoint sections (22/17/24). The strict fixture-directory loader was not weakened.pwsh -NoLogo -NoProfile -File Tools\tdd\Tests\TddEvidence.Tests.ps1passed.pwsh -NoLogo -NoProfile -File Tools\windows\validate.ps1 -Task privacypassed.git diff --checkpassed; every branch commit has its DCO sign-off and required co-author trailer.Limits: the current compiled full is green and unchanged native unit-input evidence covers all 63 shard sections, but actual corrected local nested-click input and local native integration remain unverified. The user explicitly approved a PR #956-only exception permitting these verified fixes to be pushed with that limitation disclosed. This does not waive hosted native integration, any required check, or strict up-to-date enforcement: all must pass on the new head before normal merge. These contracts and controlled fixtures do not establish hardware/glyph/visual parity or a merge result.
Checklist
git commit -s) per the DCOmake test)make check)make testandmake checkare macOS-only and were not run on this Windows host. The completed Windows commands and remaining native/final-source limits are distinguished above.