Skip to content

Get Scality libraries from the npm registry - #412

Merged
bert-e merged 4 commits into
development/1from
improvement/S3UTILS-247-scoped-deps
Sep 28, 2026
Merged

bert-e merged 4 commits into
development/1from
improvement/S3UTILS-247-scoped-deps

Conversation

@francoisferrand

@francoisferrand francoisferrand commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The Scality libraries are published to npm under scoped names now, so there is
no reason to keep fetching them from GitHub tarballs. Beyond being cleaner, this
gets rid of the nested copies those tarballs dragged along — most notably a stale
Arsenal pulling in the unmaintained native diskusage module.

Arsenal moves to @scality/arsenal, and bucketclient to the first tag that
depends on it. The others (vaultclient, werelogs, httpagent, sproxydclient)
have nothing published under @scality/* yet, so they stay on git — just using
the shorter form now.

Deduplicating the tree has a nice side effect on vulnerabilities: prod goes from
214 advisories to 3 and dev from 223 to 7, with all criticals gone. The three
resolutions are dropped too, as none of them did anything useful anymore — one
had no dependent left, one pinned a version that is already the latest, and the
last forced a downgrade yarn complained about on every install. What remains in
prod comes through an abandoned transitive dependency of arsenal, which is worth
its own ticket.

Validated with install, lint, unit tests (32 suites / 472 tests) and a docker
build — the image build being the real check that nothing still resolves a git
URL it cannot reach. Functional tests need a workbench stack and were not run.

Overlaps with the Node 24 work on bucketclient; 8.3.0 is the version that
should win.

Issue: S3UTILS-247

Arsenal is now published as @scality/arsenal, so there is no reason to
keep pulling it from a git tag. Move to 8.6, which is what bucketclient
8.3.0 expects as a peer: staying behind would leave two arsenal copies in
the tree.

That line drops the per-field replication setters on ObjectMD and makes
the site accessors take a backend key instead of a site name, part of the
move to multi-destination CRR, so the replication status updater now
reads, mutates and writes back the whole replicationInfo. prom-client is
required directly here and is only a peer of arsenal, so declare it.

The other Scality libraries (bucketclient, vaultclient, werelogs,
httpagent) are not published yet and stay on their git tags.

Issue: S3UTILS-247
Now that the Scality libraries come from the registry, the lockfile still
carried resolutions inherited from the old git-sourced tree, including a
large amount of duplicated transitive packages. Re-resolving everything
within the existing semver ranges collapses those duplicates and clears
most of the reported advisories (prod: 214 -> 3, dev: 223 -> 7).

Issue: S3UTILS-247
The three resolutions no longer serve a purpose: jsprim has no dependent
left, ioctl 2.0.2 is the latest published version anyway, and the
string-width pin forced v4 onto v5 consumers, which yarn warned about on
every install.

Issue: S3UTILS-247
@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@francoisferrand
francoisferrand changed the base branch from development/1.18 to development/1.19 September 25, 2026 20:51
@scality scality deleted a comment from bert-e Sep 25, 2026
@scality scality deleted a comment from bert-e Sep 25, 2026
@francoisferrand
francoisferrand changed the base branch from development/1.19 to development/1 September 25, 2026 20:52
@scality scality deleted a comment from bert-e Sep 25, 2026
@scality scality deleted a comment from bert-e Sep 25, 2026
@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand
francoisferrand marked this pull request as ready for review September 28, 2026 06:41
@francoisferrand

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.17
  • development/1.18
  • development/1.19
  • development/1.4
  • development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/1.14.0

Please check the status of the associated issue S3UTILS-247.

Goodbye francoisferrand.

The following options are set: approve

@bert-e
bert-e merged commit 54b9b57 into development/1 Sep 28, 2026
18 checks passed
@bert-e
bert-e deleted the improvement/S3UTILS-247-scoped-deps branch September 28, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants