Get Scality libraries from the npm registry - #412
Merged
Merged
Conversation
Arsenal is now published as @scality/arsenal, so there is no reason to keep pulling it from a git tag. Move to 8.6, which is what bucketclient 8.3.0 expects as a peer: staying behind would leave two arsenal copies in the tree. That line drops the per-field replication setters on ObjectMD and makes the site accessors take a backend key instead of a site name, part of the move to multi-destination CRR, so the replication status updater now reads, mutates and writes back the whole replicationInfo. prom-client is required directly here and is only a peer of arsenal, so declare it. The other Scality libraries (bucketclient, vaultclient, werelogs, httpagent) are not published yet and stay on their git tags. Issue: S3UTILS-247
Now that the Scality libraries come from the registry, the lockfile still carried resolutions inherited from the old git-sourced tree, including a large amount of duplicated transitive packages. Re-resolving everything within the existing semver ranges collapses those duplicates and clears most of the reported advisories (prod: 214 -> 3, dev: 223 -> 7). Issue: S3UTILS-247
The three resolutions no longer serve a purpose: jsprim has no dependent left, ioctl 2.0.2 is the latest published version anyway, and the string-width pin forced v4 onto v5 consumers, which yarn warned about on every install. Issue: S3UTILS-247
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
francoisferrand
changed the base branch from
development/1.18
to
development/1.19
September 25, 2026 20:51
francoisferrand
changed the base branch from
development/1.19
to
development/1
September 25, 2026 20:52
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
francoisferrand
marked this pull request as ready for review
September 28, 2026 06:41
DarkIsDude
approved these changes
Sep 28, 2026
benzekrimaha
approved these changes
Sep 28, 2026
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue S3UTILS-247. Goodbye francoisferrand. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scality libraries are published to npm under scoped names now, so there is
no reason to keep fetching them from GitHub tarballs. Beyond being cleaner, this
gets rid of the nested copies those tarballs dragged along — most notably a stale
Arsenal pulling in the unmaintained native
diskusagemodule.Arsenal moves to
@scality/arsenal, and bucketclient to the first tag thatdepends on it. The others (
vaultclient,werelogs,httpagent,sproxydclient)have nothing published under
@scality/*yet, so they stay on git — just usingthe shorter form now.
Deduplicating the tree has a nice side effect on vulnerabilities: prod goes from
214 advisories to 3 and dev from 223 to 7, with all criticals gone. The three
resolutionsare dropped too, as none of them did anything useful anymore — onehad no dependent left, one pinned a version that is already the latest, and the
last forced a downgrade yarn complained about on every install. What remains in
prod comes through an abandoned transitive dependency of arsenal, which is worth
its own ticket.
Validated with install, lint, unit tests (32 suites / 472 tests) and a docker
build — the image build being the real check that nothing still resolves a git
URL it cannot reach. Functional tests need a workbench stack and were not run.
Overlaps with the Node 24 work on
bucketclient; 8.3.0 is the version thatshould win.
Issue: S3UTILS-247