Skip to content

Move to Node 24 - #411

Merged
bert-e merged 1 commit into
development/1from
improvement/S3UTILS-248-node-24
Sep 25, 2026
Merged

bert-e merged 1 commit into
development/1from
improvement/S3UTILS-248-node-24

Conversation

@francoisferrand

Copy link
Copy Markdown
Contributor

Moves CI, the image and the engines floor from Node 22 to Node 24, as part of the org-wide Node 24 upgrade (OS-1155).

Two things actually broke on 24:

  • diskusage fails to compile — it uses the v8::ScriptOrigin NAN API that Node removed, and it's unmaintained (last publish 2021), so there's no version to bump to. It was only in the tree via a duplicate nested arsenal copy dragged in by bucketclient#8.2.6; bucketclient#8.2.10 makes Arsenal a peer dependency, which collapses that duplicate and drops diskusage entirely.
  • node-rdkafka 2.x doesn't build: its binding.gyp asks for C++17, but Node 24's v8/cppgc headers need C++20. 3.x builds fine. The only consumer here is requeueFailedCRRCronJob.js and it stays on API-stable Producer methods, so no code change.

Validated on Node 24.21.0: install clean, lint clean, 32 unit suites / 472 tests pass, docker build succeeds and the modules load inside the image.

Issue: S3UTILS-248

Node 22 enters maintenance in October and 24 is the active LTS until 2028,
so CI, the image and the engines floor all move to 24.

Two native dependencies did not survive the ABI/toolchain change:

- bucketclient 8.2.6 carried its own Arsenal 8.2.4, which pulled diskusage —
  unmaintained since 2021 and still on the pre-Node-24 NAN API. 8.2.10 takes
  Arsenal as a peer dependency, so we get a single copy (ours) and diskusage
  disappears from the tree.
- node-rdkafka 2.x builds with C++17, while the Node 24 headers need C++20.
  Fixed in 3.x; the Producer API we use is unchanged.

Issue: S3UTILS-248
@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.78%. Comparing base (2294584) to head (fb81c1a).

Additional details and impacted files
@@              Coverage Diff               @@
##           development/1     #411   +/-   ##
==============================================
  Coverage          45.78%   45.78%           
==============================================
  Files                 88       88           
  Lines               6555     6555           
  Branches            1383     1383           
==============================================
  Hits                3001     3001           
  Misses              3504     3504           
  Partials              50       50           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Sep 25, 2026
@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.17
  • development/1.18
  • development/1.19
  • development/1.4
  • development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/1.14.0

Please check the status of the associated issue S3UTILS-248.

Goodbye francoisferrand.

The following options are set: approve

@bert-e
bert-e merged commit fb81c1a into development/1 Sep 25, 2026
30 of 31 checks passed
@bert-e
bert-e deleted the improvement/S3UTILS-248-node-24 branch September 25, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants