Conversation
Prettier now owns line length, so drop the eslint max-len rule it conflicts with and the disable directives that went with it. Issue: CLDSRV-1002
websiteHead.js and websiteHeadWithACL.js assert the ETag of index.html, so reformatting these fixtures would change their MD5 and break the tests. Their bytes are the test data, not source to style. Issue: CLDSRV-1002
Plain output of `yarn prettier:write`, no manual edit on top. Issue: CLDSRV-1002
Prettier pads markdown table cells for alignment, which pushed this table to 82 columns and tripped MD013. mdlint's config lives in the shared Guidelines package and cannot be relaxed per repo, so shorten the widest cell instead. Issue: CLDSRV-1002
GitHub reads .git-blame-ignore-revs automatically; locally it needs git config blame.ignoreRevsFile .git-blame-ignore-revs Issue: CLDSRV-1002
…-whole-repo' into w/9.5/improvement/CLDSRV-1002/prettier-whole-repo # Conflicts: # lib/api/apiUtils/object/coldStorage.js # tests/unit/api/apiUtils/coldStorage.js
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
So that later commits can be appended each with their own comment. Issue: CLDSRV-1002
Prettier joins a broken `'...' + '...'` chain onto one line but keeps the `+` between the literals. Merge each run of adjacent string literals into a single one when it fits the print width, otherwise re-split it into as few pieces as fit. String values are unchanged. Issue: CLDSRV-1002
…ctopus/w/9.5/improvement/CLDSRV-1002/prettier-whole-repo
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| assert( | ||
| typeof details.supportsVersioning === 'boolean', | ||
| 'bad config: locationConstraints[region].supportsVersioning' + 'must be a boolean', | ||
| 'bad config: locationConstraints[region].supportsVersioningmust be a boolean', |
There was a problem hiding this comment.
The string merge exposed a pre-existing missing-space bug. Same issue at lines 1340, 1351, 1352, 1520, 1527, 1528, and 1538. The full list:
| Line | Typo |
|---|---|
| 409 | supportsVersioningmust |
| 1340 | sentinelsmust |
| 1351 | localCachesentinel host |
| 1352 | localCachesentinel port |
| 1520 | badconfig: |
| 1527 | badconfig: |
| 1528 | bad config:utapi |
| 1538 | badconfig: |
Suggested change
| 'bad config: locationConstraints[region].supportsVersioningmust be a boolean', | |
| 'bad config: locationConstraints[region].supportsVersioning must be a boolean', |
| @@ -148,7 +148,7 @@ describe('getObjMetadataAndDelete function for multiObjectDelete', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should return error results if err from metadata getting object' + 'is error other than NoSuchKey', done => { | |||
| it('should return error results if err from metadata getting objectis error other than NoSuchKey', done => { | |||
There was a problem hiding this comment.
Same missing-space issue from string merge: objectis should be object is.
Suggested change
| it('should return error results if err from metadata getting objectis error other than NoSuchKey', done => { | |
| it('should return error results if err from metadata getting object is error other than NoSuchKey', done => { |
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## development/9.5 #6303 +/- ##
===================================================
- Coverage 86.58% 86.54% -0.04%
===================================================
Files 213 213
Lines 14620 14607 -13
===================================================
- Hits 12658 12642 -16
- Misses 1962 1965 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bert-e
deleted the
w/9.5/improvement/CLDSRV-1002/prettier-whole-repo
branch
September 23, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #6297.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.5/improvement/CLDSRV-1002/prettier-whole-repo, please follow thisprocedure:
git fetch git checkout w/9.5/improvement/CLDSRV-1002/prettier-whole-repo # <amend or cancel the changeset by _adding_ new commits> git push origin w/9.5/improvement/CLDSRV-1002/prettier-whole-repoPlease always comment pull request #6297 instead of this one.