[PLA4-44978] Remove Celery autoscaler timing logs - #876
Open
samuelshih wants to merge 1 commit into
Open
samuelshih wants to merge 1 commit into
samuelshih wants to merge 1 commit into
Conversation
samuelshih
marked this pull request as ready for review
September 14, 2026 23:16
billyang-scale
approved these changes
Sep 14, 2026
samuelshih
enabled auto-merge (squash)
September 14, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Finding
The
celery-autoscaler-sqsloop emits four INFO timing statements on every iteration and for every scanned namespace:list_namespaced_deployment ... took ... secondslist_deployments took ... secondsget_metrics took ... secondsIteration length: ... secondsThis change removes only those timing statements and their now-unused timers. Queue state, scaling actions, errors, and health telemetry remain unchanged.
Datadog evidence
Frozen window: 2026-09-04 20:08:12 UTC through 2026-09-11 20:08:12 UTC.
infoevents and represents approximately 98% of indexed service volume.Estimated savings
Contract rates: $0.98 per million indexed events (7-day retention) and $0.10 per ingested GB. Monthly estimates use 30.4375 / 7.
The ingestion estimate allocates measured service bytes using the exact selector's share of service events. The full census projects 44.46B indexed events against a 26B monthly commitment and 158,475 GB ingestion against a 105,000 GB commitment, so gross usage value and projected invoice impact are currently the same.
Safety and provenance
celery_autoscaler.heartbeat, scaling success/failure metrics, deployment-update logs, queue-state logs, and every exception/error path remain intact.pup monitors searchfound eight Celery-autoscaler-related monitors and zero exact references to the removed strings. Four log monitors alert onstatus:error; four health monitors usecelery_autoscaler.heartbeat. Neither dependency is changed.The repository has no CODEOWNERS file. The autoscaler chart/workload metadata uses
team: infra; ownership should be confirmed during review.Tests
git diff --check.Rollout
Draft only. No deployment or reviewers assigned. After deploy, verify the exact query falls while
status:erroralerts, heartbeat monitors, scaling metrics, and deployment-update logs remain healthy.This PR appears safe to merge.
What we checked:
Summary
The Celery autoscaler stops writing timing logs while keeping its scaling loop and health reporting unchanged. It removes timers used only for those messages, reducing repeated INFO log volume.
Diagram
sequenceDiagram participant A as Autoscaler participant K as Kubernetes API participant B as Queue broker participant D as Datadog loop Autoscaler pass A->>K: "List deployments" K-->>A: "Return deployments" A->>B: "Read queue and worker state" B-->>A: "Return queue metrics" A->>D: "Send queue and worker gauges" A->>K: "Update worker counts" opt Pass took under three seconds A->>A: "Sleep for the remaining time" end A->>D: "Send heartbeat" Note over A,D: Timing INFO logs are no longer sent endReviews (1) · Last reviewed commit: "[PLA4-44978] Remove Celery autoscaler ti..."