Repository navigation
fix(ci): name the postcss-selector-parser advisory in the toolchain audit - #280
Closed
sasjs-dev[bot] wants to merge 2 commits into
Closed
sasjs-dev[bot] wants to merge 2 commits into
sasjs-dev[bot] wants to merge 2 commits into
Conversation
…udit The audit caught a new advisory, which is what it is for: GHSA-rj75-hqrm-r3gf, moderate, quadratic complexity in flat selector parsing. It cannot be fixed from here. The vulnerable copy is npm's own bundled dependency - release/node_modules/npm/node_modules/postcss-selector-parser - so no resolver change reaches it, and 11.21.0 is the last npm 11.x while @semantic-release/npm requires ^11. The eventual fix is that plugin moving to npm 12. It is also unreachable in this usage: the parser reads this repo's own release config, not the commits being matched. Named with that reasoning rather than silenced, so the audit still fails on anything new. 13 exempt, exit 0.
…udit The audit caught a new advisory, which is what it is for: GHSA-rj75-hqrm-r3gf, moderate, quadratic complexity in flat selector parsing. It cannot be fixed from here. The vulnerable copy is npm's own bundled dependency - release/node_modules/npm/node_modules/postcss-selector-parser - so no resolver change reaches it, and 11.21.0 is the last npm 11.x while @semantic-release/npm requires ^11. The eventual fix is that plugin moving to npm 12. It is also unreachable in this usage: the parser reads this repo's own release config, not the commits being matched. Named with that reasoning rather than silenced, so the audit still fails on anything new. 13 exempt, exit 0.
Contributor
Author
|
Superseded - folded into #279, so this is one utils change rather than two. What landed, where:
This branch is two commits old and was never reviewed, so nothing is lost by closing it here. |
![sasjs-dev[bot]](https://avatars.githubusercontent.com/u/67858352?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Reviewed the full base...main diff (release/audit.mjs alone: GHSA-rj75-hqrm-r3gf, postcss-selector-parser, added to EXEMPT with the unfixable-bundle and unreachable-here reasoning) and verified it live at the head: node release/audit.mjs reports 13 advisory(s), 13 exempt, exit 0, and the file is byte-identical to the other four repos' copies; CI (test (22)) is green at the head. No blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The toolchain audit caught a new advisory, which is what it is for:
This names it in the exemption list, with the reasoning, so the audit still fails on anything new.
Why it cannot be fixed here
The vulnerable copy is npm's own bundled dependency:
npm ships its own bundled tree, so no resolver change reaches it -
npm updateleaves it at 7.1.4, because the copy is part of the npm tarball rather than something the resolver picks. The patched version is 7.1.6, and the chain is:@npmcli/queryallows^7.0.0, so the range is not the obstacle - the bundle is. 11.21.0 is the last npm 11.x, and@semantic-release/npmrequires^11, so the eventual fix is that plugin moving to npm 12. Forcing npm 12 by override would put the release toolchain itself at risk, which is the opposite of what it is for.It is also unreachable in this usage: the selector parser reads this repo's own release config, not the commits being matched.
Verification
release/audit.mjsstays byte-identical across adapter, cli, sas-language, utils and vscode-extension (sha256 9241ea8f9e1012b8).The file is formatted with sas-language's prettier config (printWidth 100), the only one of the five that lints
release/.