Repository navigation
feat!: remove surface deprecated in 0.10.x - #3248
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remove the props, components, and aliases that already warned in development on 0.10.x: InlineEdit, ModalTrigger, Modal title and closeButtonAssistiveText, Tooltip target and the info/error variant values, string assistiveText on nine components, the forms/checkbox and tabs/pane aliases, Checkbox oldEventParameterOrder, and the FORMS_INLINE_EDIT constant. BREAKING CHANGE: InlineEdit/SLDSInlineEdit and ModalTrigger/SLDSModalTrigger are no longer exported. Modal drops title (use heading) and closeButtonAssistiveText (use assistiveText.closeButton). Tooltip drops target (use onRequestTargetElement) and the info/error variant values (use theme). Avatar, Breadcrumb, Button, ButtonStateful, Checkbox, Search, Spinner, Textarea, and Tree accept only an object for assistiveText. The components/forms/checkbox and components/tabs/pane paths, Checkbox oldEventParameterOrder, and FORMS_INLINE_EDIT are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
interactivellama
force-pushed
the
feat/remove-deprecated-surface
branch
from
October 27, 2026 01:47
03c0600 to
0fb625a
Compare
interactivellama
approved these changes
Oct 27, 2026
interactivellama
added a commit
that referenced
this pull request
Oct 27, 2026
…base #3248 removed Modal's check-props module and its checkProps call; the callback-shapes rebase reintroduced the import and the componentDoc import. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
interactivellama
added a commit
that referenced
this pull request
Oct 27, 2026
* feat!: standardize v11 callback shapes on (event, data)
Callbacks across Tabs, MenuDropdown, Carousel, SetupAssistant, Popover,
Tree, SplitView, PillContainer, Toast, Modal, WelcomeMat and DatePicker
now receive (event, data), report the requested state in data, and have
exported data types. Old Tree, SplitView and PillContainer callbacks are
deprecated with one-time warnings rather than removed.
BREAKING CHANGE: Tabs onSelect is called as onSelect(event, { selectedIndex,
previousIndex }) and returning false no longer cancels the selection.
MenuDropdown onSelect is called as onSelect(event, { option, optionIndex }).
Carousel onRequestAutoplayToggle and SetupAssistant onStepToggleIsOpen /
SetupAssistantStep onToggleIsOpen data report the requested state. Popover
onRequestClose data always includes a trigger. See CHANGELOG.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(modal): drop check-props and component.json leftovers from the rebase
#3248 removed Modal's check-props module and its checkProps call; the
callback-shapes rebase reintroduced the import and the componentDoc import.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Stephen James <sjames@salesforce.com>
interactivellama
added a commit
that referenced
this pull request
Oct 29, 2026
* feat!: standardize v11 callback shapes on (event, data)
Callbacks across Tabs, MenuDropdown, Carousel, SetupAssistant, Popover,
Tree, SplitView, PillContainer, Toast, Modal, WelcomeMat and DatePicker
now receive (event, data), report the requested state in data, and have
exported data types. Old Tree, SplitView and PillContainer callbacks are
deprecated with one-time warnings rather than removed.
BREAKING CHANGE: Tabs onSelect is called as onSelect(event, { selectedIndex,
previousIndex }) and returning false no longer cancels the selection.
MenuDropdown onSelect is called as onSelect(event, { option, optionIndex }).
Carousel onRequestAutoplayToggle and SetupAssistant onStepToggleIsOpen /
SetupAssistantStep onToggleIsOpen data report the requested state. Popover
onRequestClose data always includes a trigger. See CHANGELOG.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(modal): drop check-props and component.json leftovers from the rebase
#3248 removed Modal's check-props module and its checkProps call; the
callback-shapes rebase reintroduced the import and the componentDoc import.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Stephen James <sjames@salesforce.com>
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional description
What: removes the props, components, and import paths that 0.10.x already flagged with dev-only deprecation warnings (ROADMAP: Deprecated surface). v11 kept them working; this drops them before v11 leaves alpha. Each item lists its replacement in
CHANGELOG.mdunder Removed.Breaking changes and migration:
InlineEdit/SLDSInlineEdit(components/forms/input/inline)InputwithinlineEditTrigger(the prop stays)ModalTrigger/SLDSModalTriggerModalwithisOpen; it already portals tobodyModaltitleheadingModalcloseButtonAssistiveTextassistiveText.closeButtonTooltiptargetonRequestTargetElementTooltipvariant="info"/"error"themeassistiveTextonAvatar,Breadcrumb,Button,ButtonStateful,Checkbox,Search,Spinner,Textarea,TreeassistiveText={{ label: 'Loading' }}; see each component'sassistiveTexttype for its keyscomponents/forms/checkboxpathcomponents/checkboxcomponents/tabs/panepathcomponents/tabs/panelCheckboxoldEventParameterOrderFORMS_INLINE_EDITinutilities/constantscomponents/forms/checkboxandcomponents/tabs/panewere never shipped as JavaScript in v11, so only their type declarations and source go away.Supporting cleanup:
check-props.jsfor Avatar, Breadcrumb, ButtonStateful, Modal, and Spinner, plusutilities/warning/deprecated-event-parameter.js. The remainingcheck-props.jsfiles lose only the removed checks.oldEventParameterOrder.ROADMAP.md:formsno longer appears in the lists of folders without a story or test.Out of scope:
closeButtonAssistiveText: it's a separate prop with its own deprecation warning.types/components.ts: it still declares acloseButtonAssistiveTexton aModalPropsinterface. The package's types come from the generateddist/typesfiles, so this file isn't part of what consumers get; it looks stale and could be deleted in a follow-up.Merge note: the boolean prop rename PR (
feat/boolean-prop-names) adds rename warnings tocheck-props.jsfiles that this PR deletes: Avatar, ButtonStateful, Modal, and Spinner. It also keeps Checkbox's import ofdeprecated-event-parameter. Whichever PR merges second needs a rebase. When resolving:check-props.jsfiles, containing only the boolean rename warnings.checkPropsimport and call incomponents/modal/index.tsx.Tests: removed props and paths are covered by typecheck and the build: nothing in the library, examples, or stories still uses them. No new tests; the only test change is the deleted InlineEdit test. Locally: 49 test files and 1,017 tests pass, lint has 0 errors (222 warnings, one fewer than
master), and typecheck and build are clean.CONTRIBUTOR checklist (do not remove)
Please complete for every pull request.
Green gate — all of these must pass locally (CI runs the same):
npm run lintpasses with 0 errors (npm run lint:fixto auto-fix). Warnings are the tracked gradual-migration backlog; do not add new errors.npm run typecheckis clean (tsc --noEmit).npm test -- --runpasses — this runs both Vitest projects (jsdomunit+ real-browserbrowser) and the story HTML snapshots. If you changed rendered markup on purpose, update snapshots withnpm test -- --run -uand review the diff.npm run buildsucceeds (type-check + Vite library build +.d.ts+ entry shims).Behavior & docs:
components/button/__tests__). New props and bug fixes should get a regression test. Tests that genuinely need a real browser (focus traversal, layout/measurement, canvas) go in a*.browser.test.jsxfile (thebrowserproject); everything else is jsdom.npm run storybook→ http://localhost:6007/. Confirm the story actually renders and behaves (deprecated Storyshots/Karma are gone; there is no separate browser-tests server).onRenderContent/onRenderVisualPicker,iconprops,events), not assumptions — a common source of "component looks broken" reports has been stories authored against the wrong API. Cross-check againstcomponents/<name>/__examples__..d.ts(they're generated by the build); JS consumers rely on them via editor type-acquisition.REVIEWER checklist (do not remove)
CIworkflow: lint, typecheck, test, build). Chromatic visual review, if configured, has been checked.components/__tests__/__snapshots__/story-snapshots.test.jsx.snap).@salesforce/design-system-react/components/<name>and nested paths resolve for ESM, CJS, and types). Removing/renaming a public component or export is a breaking change →feat!:/BREAKING CHANGE:and a major version bump.