Skip to content

Give the code index status check its own warm step and a 5-minute limit - #202

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1795108944-code-status-step
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1795108944-code-status-step

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refs #144 (items 1 and 2 of its proposed fix). On a large repository, warmOne killed ox code status --json at 30 s right after a successful ox index code. Because the status check never entered its own step, failureReading reported index-failed ("could not be built … check that ox is installed"), which was false.

  • New warm step checking ("the code index is built and its status is being read").
  • ox code status limit raised from 30 s to 5 min (STATUS_TIMEOUT_MS). ox runs a full PRAGMA integrity_check on every writable open.
  • A failure in that step reads as the new ProbeFailure status-failed. When Node killed the child at the limit, the reason names the limit. The text comes from the toolkit, never from ox's stderr.

Not done here: item 3 of the issue (re-probe a failed reading instead of holding it until restart). warm() is still memoized.

Test Plan

  • New repos.test.ts case, "reports a slow status check after a built index as a status failure, not a failed build". It failed with the fix reverted (expected … to contain 'failure=status-failed') and passes with it.
  • vitest run packages/cli/test/repos.test.ts packages/core/test/health.test.ts: 39 passed.
  • pnpm typecheck passes.

Checklist (expand if needed)
  • Tests added, or N/A documented
  • pnpm typecheck && pnpm test green (touched suites; full suite left to CI)
  • Deployment checks run if deploy/ changed (N/A)
  • CHANGELOG entry added if user-facing
  • Breaking change documented (none)
  • Docs updated if behavior or configuration changed (N/A)

Link to Devin session: https://app.devin.ai/sessions/0ebd287b03ba45019eb9c93a5f18ed95
Open in Devin Desktop: https://app.devin.ai/desktop/session/0ebd287b03ba45019eb9c93a5f18ed95?variant=devin


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

Summary by CodeRabbit

  • Bug Fixes
    • Status checks after a successful index build now receive up to five minutes to complete. If a check fails or times out, the workspace is reported as unavailable with a distinct status-check failure, rather than an index failure.

Refs #144

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@veria-ai

veria-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Repository warmup now runs ox code status --json as a separate checking phase with a five-minute timeout. Failures in that phase are reported as status-failed, with timeout details when applicable.

Changes: Repository warmup status check

Layer / File(s) Summary
Add the status-check phase
packages/cli/src/repos.ts
Warmup adds a checking phase and allows ox code status --json five minutes to complete.
Report status-check failures
packages/core/src/health.ts, packages/cli/src/repos.ts, packages/cli/test/repos.test.ts, CHANGELOG.md
The failure category includes status-failed. Checking-phase failures report status-read details. A test verifies timeout reporting and the five-minute limit. The changelog records the change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: shrimalmadhur

Merge Risk: Minimal · up to a9f4a

This change gives the slow code index status check its own step and a five-minute limit. Failures are now reported as status failures instead of misleading index-build failures. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: a dedicated warm step for the code index status check, plus a five-minute limit. The raw summary confirms the changeset adds a checking warm step, a 5-minute `STATUS…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: a dedicated warm step for the code index status check, plus a five-minute limit. The raw summary confirms the changeset adds a checking warm step, a 5-minute STATUS_TIMEOUT_MS, and status-failed reporting. The title is concise, specific, and matches the PR objectives.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between b3f22bc and a9f4a35.

Files selected for processing: 4

  • CHANGELOG.md
  • packages/cli/src/repos.ts
  • packages/cli/test/repos.test.ts
  • packages/core/src/health.ts

Limit details: You’ve used all 3 included reviews currently available. Your 77 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the longer check runs in the background and keeps its current state visible.

Reviews (1) · Last reviewed commit: "Give the code index status check its own..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant