Repository navigation
Give the code index status check its own warm step and a 5-minute limit - #202
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Refs #144 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
PR overviewNo security issues were found in this pull request. Reviews
|
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] The PR appears safe to merge; the longer check runs in the background and keeps its current state visible. Reviews (1) · Last reviewed commit: "Give the code index status check its own..." · Reviewed by Greptile |
Summary
Refs #144 (items 1 and 2 of its proposed fix). On a large repository,
warmOnekilledox code status --jsonat 30 s right after a successfulox index code. Because the status check never entered its own step,failureReadingreportedindex-failed("could not be built … check thatoxis installed"), which was false.checking("the code index is built and its status is being read").ox code statuslimit raised from 30 s to 5 min (STATUS_TIMEOUT_MS). ox runs a fullPRAGMA integrity_checkon every writable open.ProbeFailurestatus-failed. When Node killed the child at the limit, the reason names the limit. The text comes from the toolkit, never from ox's stderr.Not done here: item 3 of the issue (re-probe a failed reading instead of holding it until restart).
warm()is still memoized.Test Plan
repos.test.tscase, "reports a slow status check after a built index as a status failure, not a failed build". It failed with the fix reverted (expected … to contain 'failure=status-failed') and passes with it.vitest run packages/cli/test/repos.test.ts packages/core/test/health.test.ts: 39 passed.pnpm typecheckpasses.Checklist (expand if needed)
pnpm typecheck && pnpm testgreen (touched suites; full suite left to CI)deploy/changed (N/A)Link to Devin session: https://app.devin.ai/sessions/0ebd287b03ba45019eb9c93a5f18ed95
Open in Devin Desktop: https://app.devin.ai/desktop/session/0ebd287b03ba45019eb9c93a5f18ed95?variant=devin
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit