Skip to content

Fix may not to appropriate might not or must not - #87445

Merged
bors merged 2 commits into
rust-lang:masterfrom
amalik18:issue-83584-fix
Jul 30, 2021
Merged

Fix may not to appropriate might not or must not#87445
bors merged 2 commits into
rust-lang:masterfrom
amalik18:issue-83584-fix

Conversation

@amalik18

@amalik18 amalik18 commented Jul 25, 2021

Copy link
Copy Markdown

I went through and changed occurrences of may not to be more explicit with might not and must not.

@rust-highfive

rust-highfive commented Jul 25, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@amalik18 amalik18 mentioned this pull request Jul 27, 2021
Closed
kennytm
kennytm reviewed Jul 27, 2021
View reviewed changes
Comment thread library/alloc/src/sync.rs Resolved
Comment thread library/core/src/marker.rs Resolved
Comment thread library/core/src/sync/atomic.rs Resolved
@bors

bors commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #85874) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kennytm

kennytm commented Jul 29, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit ffcf8a0 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2021
@bors

bors commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ffcf8a0 with merge 260af5fb771243a2d36a04c177dc7307f16253c2...

@bors

bors commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2021
@rust-log-analyzer

rust-log-analyzer commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@amalik18

amalik18 commented Jul 30, 2021

Copy link
Copy Markdown
Author

@kennytm How do I view why it failed? I'm not able to pull up the build logs.

@kennytm

kennytm commented Jul 30, 2021

Copy link
Copy Markdown
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2021
@bors

bors commented Jul 30, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ffcf8a0 with merge fe1c942...

@bors

bors commented Jul 30, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing fe1c942 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 30, 2021
@bors
bors merged commit fe1c942 into rust-lang:master Jul 30, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 30, 2021
This was referenced Jul 30, 2021
Merged
Closed
@amalik18
amalik18 deleted the issue-83584-fix branch July 30, 2021 13:40
@taylordotfish taylordotfish mentioned this pull request Apr 6, 2024
Closed
@clarfonthey clarfonthey added A-panic Area: Panicking machinery A-io Area: `std::io` (note: `std::fs`, `std::net`, `std::path` are A-filesystem, A-net, A-path) A-fmt Area: `core::fmt` labels Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

Assignees

@kennytm kennytm

Labels

A-fmt Area: `core::fmt` A-io Area: `std::io` (note: `std::fs`, `std::net`, `std::path` are A-filesystem, A-net, A-path) A-panic Area: Panicking machinery merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

7 participants

@amalik18 @rust-highfive @rust-log-analyzer @bors @kennytm @clarfonthey @rustbot